Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by teor@teor

macOS i386 fails time unit tests

circuitmux/compute_ticks: [forking] 
  FAIL src/test/test_circuitmux.c:109: assert(rem OP_LT .150000001): 0.1505 vs 0.15
  [compute_ticks FAILED]
mainloop/update_time_jumps: [forking] 
  FAIL src/test/test_mainloop.c:115: expected log to not contain entries  Captured logs:
    1. notice: "Your system clock just jumped 1800 seconds forward; assuming established circuits no longer work.\n"

  [update_time_jumps FAILED]

Should we set up macOS i386 CI to detect issues like this? Or should we remove macOS i386 from our supported platforms? (Apple won't support i386 in the next macOS, so in ~3 years time, we won't need to support it.)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information