'mk_add_options' or 'export' MOZILLA_OFFICIAL

In #27472 (moved), we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export? Should we use export on the desktop builds, too?

added TorBrowserTeam201909R actualpoints::0.1 component::applications/tor browser owner::tbb-team parent::30320 points::0.1 priority::medium resolution::fixed severity::normal status::closed tbb-9.0-must-alpha type::enhancement labels

Replying to sysrqb:

In #27472 (moved), we added export MOZILLA_OFFICIAL=1 in .mozconfig-android because we found the compiled APK wasn't releasable (it was still debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for release. Do we need both mk_add_options and export or do we only need export? Where did you get that mk_add_options trash? From pre-esr era? Mozilla removed almost all occurences of it, read https://dxr.mozilla.org/mozilla-esr60/source/build/docs/mozconfigs.rst#31 Should we use export on the desktop builds, too? Not you, but tbb-team, and long ago. That's #27623 (moved) now.

Trac:
Username: reportUrl

Hrm, also look at https://dxr.mozilla.org/mozilla-esr60/source/browser/config/mozconfigs/whitelist

Trac:
Username: reportUrl

That'll be done in #30429 (moved).

Trac:
Parent: N/A to #30429 (moved)

Trac:
Points: N/A to 0.25
Keywords: N/A deleted, TorBrowserTeam201902, tbb-9.0-must-alpha added

Trac:
Points: 0.25 to 0.1

TorBrowserTeam201902 0_o

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

Trac:
Keywords: TorBrowserTeam201902 deleted, TorBrowserTeam201909 added

Trac:
Parent: #30429 (moved) to #30320 (moved)

Hrm, also look at ​https://dxr.mozilla.org/mozilla-esr60/source/browser/config/mozconfigs/whitelist That's about https://dxr.mozilla.org/mozilla-release/search?q=BUILDING_RELEASE

+ac_add_options --enable-rust-simd?

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: new to needs_review

Replying to cypherpunks:

+ac_add_options --enable-rust-simd?

That could be done in a different bug if Mozilla set it in ESR 68. However, I don't see that to be the case.

They forgot. Only that: https://hg.mozilla.org/mozreview/gecko/rev/de0f0fa6f19d116db5e6d05ade564b3e990814da#l1.12

#31308 (moved) is duplicate.

Yes, Mozilla sets it and LTO in ESR 68.

#31813 (moved) is duplicate.

Trac:
Cc: N/A to sysrqb

Replying to gk:

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

This looks good to me. The change is deleting non-existant options, deleting deprecated syntax, deleting comments, or adding ac_add_options --enable-proxy-bypass-protection.

Trac:
Status: needs_review to merge_ready

Replying to sysrqb:

Replying to gk:

Replying to gk:

bug_27493 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27493&id=e361790e2540af786386b6a13ac9477d82267db7) has the changes. I still need to test them.

This works for me.

This looks good to me. The change is deleting non-existant options, deleting deprecated syntax, deleting comments, or adding ac_add_options --enable-proxy-bypass-protection.

Thanks! Merged to master (commit ec79824470dcd6815ffd903c8c9974808859f9e5).

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed
Actualpoints: N/A to 0.1

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #30429 (moved)

mentioned in issue #31308 (moved)

mentioned in issue #31813 (moved)

mentioned in issue #30320 (moved)

moved to tpo/applications/tor-browser#27493 (closed)