Use mingw-w64/clang toolchain to build Firefox
We want to use the clang-based mingw-w64 toolchain to build Firefox to be finally able to enabled Stylo on Windows as well. This is the ticket tracking the implementation work
Activity
We likely start small and just use the toolchain to build the Firefox part which means we'd have two mingw-w64 toolchains for the time being (we had this back then in the old days for macOS, too). I guess other parts of the whole bundle might need quite some amount of work to getting built with that new toolchain and we want to move fast here aiming for Tor Browser 8.5.
However, if it turns out I am wrong and it is indeed easy to use mingw-w64/clang for everything, fine with me.
-
Testing
bug_28238shows that we have some reproducibility issues with mingw-w64/clang. It seems we have to deal at least with timestamp issues in the COFF header. Comparing e.g.firefox.exefrom two different runs shows:--- /dev/fd/63 2019-01-10 09:38:08.159230047 +0100 +++ /dev/fd/62 2019-01-10 09:38:08.159230047 +0100 @@ -6,7 +6,7 @@ 00000050: 6973 2070 726f 6772 616d 2063 616e 6e6f is program canno 00000060: 7420 6265 2072 756e 2069 6e20 444f 5320 t be run in DOS 00000070: 6d6f 6465 2e24 0000 5045 0000 4c01 0600 mode.$..PE..L... -00000080: 3b1c 365c 003c 0000 a201 0000 e000 2201 ;.6\.<........". +00000080: 45ff 365c 003c 0000 a201 0000 e000 2201 E.6\.<........". 00000090: 0b01 0e00 001e 0000 001a 0000 0000 0000 ................ 000000a0: c013 0000 0010 0000 0000 0000 0000 4000 ..............@. 000000b0: 0010 0000 0002 0000 0600 0000 0000 0000 ................ -
Replying to gk:
Testing
bug_28238shows that we have some reproducibility issues with mingw-w64/clang. It seems we have to deal at least with timestamp issues in the COFF header. Comparing e.g.firefox.exefrom two different runs shows: {{{ --- /dev/fd/63 2019-01-10 09:38:08.159230047 +0100 +++ /dev/fd/62 2019-01-10 09:38:08.159230047 +0100 @@ -6,7 +6,7 @@ 00000050: 6973 2070 726f 6772 616d 2063 616e 6e6f is program canno 00000060: 7420 6265 2072 756e 2069 6e20 444f 5320 t be run in DOS 00000070: 6d6f 6465 2e24 0000 5045 0000 4c01 0600 mode.$..PE..L... -00000080: 3b1c 365c 003c 0000 a201 0000 e000 2201 ;.6.<........". +00000080: 45ff 365c 003c 0000 a201 0000 e000 2201 E.6.<........". 00000090: 0b01 0e00 001e 0000 001a 0000 0000 0000 ................ 000000a0: c013 0000 0010 0000 0000 0000 0000 4000 ..............@. 000000b0: 0010 0000 0002 0000 0600 0000 0000 0000 ................ }}}FWIW: That's still an unsolved issue after bumping the LLVM revision to r348363.
-
Replying to ld:
https://bugs.chromium.org/p/chromium/issues/detail?id=533657 https://bugs.llvm.org/show_bug.cgi?id=24740#c3
That's about building clang deterministic, yes. Thus, this is more suited for #29041 (moved).
https://bugs.llvm.org/show_bug.cgi?id=35914
Trac:
Username: ld-
https://reviews.llvm.org/rL332613 seems like the relevant revision for the timestamp issue.
-
So, I have been fighting today with building the whole Firefox related part (including
fxc2) without the old mingw-w64/gcc-based toolchain.fxc2does not want and I don't know why yet. It fails to run with things like0:03.01 err:module:import_dll Library api-ms-win-crt-convert-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-heap-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-private-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-runtime-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-stdio-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-string-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-environment-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-math-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-time-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.03 err:module:import_dll Library api-ms-win-crt-locale-l1-1-0.dll (which is needed by L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe") not found 0:03.03 err:module:LdrInitializeThunk Main exe initialization for L"Z:\\var\\tmp\\dist\\fxc2\\bin\\fxc2.exe" failed, status c0000135I need to look closer at the way this is built on Mozilla infra tomorrow where this seems to be working.
-
Replying to gk:
So, I have been fighting today with building the whole Firefox related part (including
fxc2) without the old mingw-w64/gcc-based toolchain. No, no, don't fight with it! The new tool chain is much more sane. And it will make you happy.fxc2does not want and I don't know why yet. It fails to run with things like {{{ 0:03.01 err:module:import_dll Library api-ms-win-crt-convert-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-heap-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-private-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-runtime-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.01 err:module:import_dll Library api-ms-win-crt-stdio-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-string-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-environment-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-math-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.02 err:module:import_dll Library api-ms-win-crt-time-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.03 err:module:import_dll Library api-ms-win-crt-locale-l1-1-0.dll (which is needed by L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe") not found 0:03.03 err:module:LdrInitializeThunk Main exe initialization for L"Z:\var\tmp\dist\fxc2\bin\fxc2.exe" failed, status c0000135 }}} Do you have wine with ucrt? FWIW, wine 4.0 is out. I need to look closer at the way this is built on Mozilla infra tomorrow where this seems to be working. They use https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/scripts/misc/build-wine.shTrac:
Username: fxc2 -
Okay, I am close with this ticket. Here is a test bundle which compiles fxc2 and firefox with mingw-w64/clang while mingw-w64/gcc is used for the remaining components. I'd be interested in whether that explodes on anyone's machine:
https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly_28238_1_en-US.exe https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly_28238_1_en-US.exe.asc
-
Here is a 32bit one to try out:
https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_1_en-US.exe https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_1_en-US.exe.asc
Trac:
Parent: N/A to #29318 (moved) Whoa! Cypherpunks operational!
Of course, that explodes, but whether I'm the only one who is interested in it?
Trac:
Parent: #29318 (moved) to N/Aoops
Trac:
Parent: N/A to #29318 (moved)-
Replying to cypherpunks:
Whoa! Cypherpunks operational!
Of course, that explodes, but whether I'm the only one who is interested in it?
Care to give more context? Which of the bundles did you test? On which Windows version? What happened? What error did you get, if any?