Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #28305
Closed (moved) (moved)
Open
Issue created Nov 03, 2018 by Karsten Loesing@karsten

Include client numbers even if we think we got reports from more than 100% of all relays

The estimated fraction of reported user statistics from relays has reached 100% and even went slightly beyond that number to 100.294% on 2018-10-27 and 100.046% on 2018-10-28.

The effect is that we're excluding days when this happened from statistics, because we never thought this was possible:

WHERE a.frac BETWEEN 0.1 AND 1.0

However, I think this is most likely a rounding error somewhere, not a general issue with the approach. Stated differently, it seems wrong to include a number with a fraction of reported statistics of 99.9% but not one where that fraction is 100.1%.

I suggest that we drop the upper limit and change the line above to:

WHERE a.frac >= 0.1

We'll be replacing these statistics by PrivCount in the medium term anyway.

However, simply excluding data points doesn't seem like an intuitive solution.

Thoughts?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking