Fetching latest commits fails when building testbuilds
Trying to build a test build on one of my build machines surprisingly failed during the fetch step with the following error:
./rbm/rbm build release --target testbuild --target torbrowser-windows-i686 fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository Error: Error fetching git repository Makefile:117: recipe for target 'testbuild-windows-i686' failed
rbm showed me that this happens when
git is trying to fetch the latest commits for the
tor repo but there aren't any new ones. I compared the
rbm config etc. with one of my other build machines where this issue does not show up and the only difference I found so far is the
git version. On the succeeding machine I have 2.11.0 and on the failing one 2.1.4.
So, I am assuming right now that something between those versions got fixed in
git that made the error go away. We should (a) figure out whether that theory is correct and, if so, (b) think about whether we want to support the older
git versions affected by this and, if so, (c) think about a good workaround.