Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #29786

Closed (moved)
(moved)
Open
Created Mar 14, 2019 by Mike Perry@mikeperry

Path bias circuits can still have cells pending

In #25773 (moved), we realized that half-closed connections need to be checked for extra cells when the circuit has been switched to path bias testing. The checks were added to the top of circuit_receive_relay_cell(), by calling pathbias_check_probe_response() to check if the path bias probe was correct, and if not, we call pathbias_count_valid_cells() to check if the cell is from a previous half-closed connection.

In https://github.com/mikeperry-tor/vanguards/issues/37, we learned that path bias circuits can still have a pending cell for onion services. In particular, there can be outstanding cells for RELAY_COMMAND_INTRO_ESTABLISHED, RELAY_COMMAND_RENDEZVOUS_ESTABLISHED, and RELAY_COMMAND_INTRODUCE_ACK, depending on circuit type.

There's sloppy ways to fix this, which are easy (just hack pathbias_count_valid_cells() to allow 1 cell for those circuit types) and precise ways (actually track if the pending cell has been received or not before and after path bias transition).

We should probably fix this the precise way, and just implement the hacky workaround in vanguards for now.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking