Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #30172

Closed (moved)
Open
Opened Apr 12, 2019 by Mike Perry@mikeperry

Always send PADDING_NEGOTIATE if middle supports it

We should define some kind of NULL machine for whatever hop is most common in our padding machine list, and negotiate that machine if no other machines apply to the current circuit. This machine shouldn't take up a slot or count as negotiated, tho, so we can still negotiate other machines at later points if the circuit purpose changes, etc.

Similarly, this NULL machine should (maybe) set should_negotiate_end and send a PADDING_NEGOTIATE at circuit close.

We need to do this so that there isn't an obvious PADDING_NEGOTIATE cell request/response pair with obvious timings that it went to the middle node (since the PADDING_NEGOTIATED response will come faster than all other responses on the circuit). See also #30092 (moved) for similar motivating reasoning.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#30172