prop289: Add consensus param to use or not SENDME v1 for one-hop directory download

See proposal 289 section 4.5 which is about adding a consensus param that controls the minimum version to use when doing one-hop directory connections.

changed milestone to %Tor: 0.4.1.x-final

Trac:
Parent Ticket: #26288 (moved)

added 041-must 0411-alpha actualpoints::0.2 component::core tor/tor milestone::Tor: 0.4.1.x-final owner::dgoulet parent::26288 points::1 postfreeze-ok priority::very high prop289 resolution::wontfix reviewer::nickm sendme severity::normal status::closed type::enhancement labels

PR: https://github.com/torproject/tor/pull/1027 Branch: ticket30364_041_01

The "onehop" concept was dropped because it is actually not reliable to figure that out but also it doesn't matter if we have a 3 hop or 1 hop I believe.

In the end, any directory requests on a circuit will result in honoring this SENDME version from the consensus param. It is actually hard to associate a circuit to a hidden service directory request at the server side. Not impossible but hard.

Trac:
Actualpoints: N/A to 0.2
Status: assigned to needs_review

Trac:
Keywords: N/A deleted, 0411-alpha added

Trac:
Keywords: N/A deleted, postfreeze-ok added

Trac:
Keywords: N/A deleted, 041-must added

Trac:
Reviewer: N/A to nickm

I've left some comments on the PR. There's some stuff here that looks wrong, and other stuff I don't understand.

Trac:
Status: needs_review to needs_revision

Interesting... I have one question there that will drive quite a bit how everything else is fixed. Once that is clarified, I might just submit an _02 since like more than 50% of the patch will change... Thanks!

Trac:
Status: needs_revision to needs_information

Trac:
Status: needs_information to needs_revision

After discussion with nickm on IRC, we'll drop this idea and instead go with this deployment plan:

1. emit=v1, accept=v0, protover=v0
2. emit=v1, accept=v0, protover=v1
3. emit=v1, accept=v1, protover=v1

Bottom line is that during phase 2, we will exit() all tor that do not support SENDME >= v1 but still accept v0 so bootstrapping tor can learn what is required. Finally, phase 3 will stop all this madness and normalize everyone to v1.

This mean that we'll drop this ticket entirely. I've opened #30557 (moved) for the change on the spec.

Trac:
Resolution: N/A to wontfix
Status: needs_revision to closed

closed

changed time estimate to 8h

added 1h 36m of time spent

moved to tpo/core/tor#30364 (closed)