Skip to content
Snippets Groups Projects
  • View options
  • View options
  • Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    • Georg Koppen

      We have

          <div id="torbrowser-info">
            <div id="torbrowser-version"/>
            <div id="torbrowser-changelog-link"><a href="about:tbupdate">&aboutTor.viewChangelog.label;</a></div>
          </div>

      in aboutTor.xhtml and

      body[mobile] #torbrowser-info,
      body[mobile] .searchbox,
      body[mobile] .top .heading2,
      body[mobile] #manual,
      body[mobile] #mission {
        display: none;
      }

      Which is presumably why the version number is not shown on mobile. It's not clear why we decided to not show all the things in torbrowser-info on mobile but sysrqb thinks that might be due to about:tbupdate not be available there. I guess we could just set display:none; on mobile for torbrowser-changelog-link instead?

      Trac:
      Component: - Select a component to Applications/Tor Browser
      Keywords: N/A deleted, tbb-torbutton added
      Owner: N/A to tbb-team

    • Mark Smith

      Replying to gk:

      We have {{{

      }}} in aboutTor.xhtml and {{{ body[mobile] #torbrowser-info, body[mobile] .searchbox, body[mobile] .top .heading2, body[mobile] #manual, body[mobile] #mission { display: none; } }}} Which is presumably why the version number is not shown on mobile. It's not clear why we decided to not show all the things in torbrowser-info on mobile but sysrqb thinks that might be due to about:tbupdate not be available there. I guess we could just set display:none; on mobile for torbrowser-changelog-link instead?

      I think so, yes. Most of the hidden items were added during the #27111 (moved) work (commit 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054). Kathy and I introduced #torbrowser-info during our work on #29440 (moved) (commit 82a5f8665a6b5a7f5d4c78f0a526dfa16834ec7f).

      I have branch bug30943 ready for review.

      Trac:
      Keywords: N/A deleted, TorBrowserTeam201909R added
      Status: new to needs_review

    • Georg Koppen

      Looks good to me (fwiw, the branch was in the Torbutton repo). Applied to master as commit 2abe720e3f1dbe1b49b41fe78719f318407babd0.

      Trac:
      Status: needs_review to closed
      Resolution: N/A to fixed

      Taking a guess.

      Trac:
      Points: N/A to 0.5
      Actualpoints: N/A to 0.5

    • Trac changed time estimate to 4h
    • Trac added 4h of time spent