- Truncate descriptions
Activity
Replying to antonela:
I wonder if we can re-use the code/implementation from the end of year banner. If yes, I'll prepare some versions based on it.
I guess that depends on how the fundraising banner should look like and behave. If it should be essentially the same functionality/look, then yes.
Trac:
Description: Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.2?) which should happen on 2019-07-09to
Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.3) which should happen around 2019-07-09.
The banner should come off on the following TBB security update, which should happen around 2019-09-03.
Art: Defenders of Privacy logo or image of patch
Link to: https://donate.torproject.org/monthly-giving
Proposed copy: Automatic monthly donations keep Tor strong. Become a Defender of Privacy today.
Proposed functionality: Each user will see the banner three times. Any user that Xs out of the banner will not see it again.
Trac:
icon_monthly_donors.zipPatch for review: https://github.com/acatarineu/torbutton/commit/30577
Note: did not find the translations, I am assuming they are not ready yet. Will update the patch once they are.
Some comments:
I am a bit wary using
extensions.torbutton.donation_banner_countdown
as we had this one already in our last year-end-campaign and some users might still have this pref set to0
in their profile. I guess we can useextensions.torbutton.donation_banner_countdown3
instead?Nit:
// Show the Sign Up for Tor News banner a finite number of times.
no Tor News here but the donation banner.Re the language strings: The usual flow is defining the necessary ones for
en-US
and commit that and then the translations get done/added once they are ready. Thus, creating proper entries inaboutTor.dtd
seems to be the way forward. I guess that could mean two entries for the two sentences, likeaboutTor.donationBanner3.line1
andaboutTor.donationBanner3.line2
, given that we only want to make the second one a link?Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201907 added