Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #30858

Closed (moved)
Open
Opened Jun 12, 2019 by teor@teor

Load geoip and geoip6 files during the unit tests

We don't run any tests on the contents of the geoip and geoip6 files.

We should write a test that loads the files, and fails if they fail to parse, are empty, or have an unexpected number of entries. (+-25% of the current number of entries?)

We might want a #define that skips the test, so that people can build and test without geoip. (We might eventually want geoip to be an optional module, but that's out of scope.)

Maybe karsten can tell us how much the number of entries in the geoip files varies?

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#30858