Review proposal 306: IPv6 "Happy Eyeballs" for Tor clients

Hi review assigners,

Please assign a network team member to review proposal 306: IPv6 "Happy Eyeballs" for Tor clients

Here is the pull request: https://github.com/torproject/torspec/pull/86

Here is the mailing list thread, and my initial review: https://lists.torproject.org/pipermail/tor-dev/2019-June/013907.html

Neel has pushed my suggested changes as fixups.

changed milestone to %Tor: unspecified

Trac:
Parent Ticket: #29801 (moved)

added 042-deferred-20190918 component::core tor/tor ipv6 milestone::Tor: unspecified parent::29801 priority::medium prop299 resolution::fixed reviewer::asn reviewer::nickm severity::normal status::closed type::task labels

It looks like dgoulet has the connection, circuit, and IPv6 knowledge needed to review this proposal.

Trac:
Reviewer: N/A to dgoulet

Neel has submitted the latest version of his proposal to the tor-dev mailing list. Here is my next review:

I have some overall comments on the proposal:

1. The proposal is very large now. Let's add an intro section that splits the changes into:

• initial feasability testing
• minimum viable product
• parameter tuning
• optional features, and how we will know if we need them

2. Bridges can't be configured with an IPv4 and an IPv6 address in tor, because tor only accepts one IP address per bridge. Let's be clear that bridges are out of scope. (Tor already attempts to connect to all? its configured bridges.)
3. Each revision of this proposal has added text. Is there any text that is redundant or not useful. Can we make it shorter?

Trac:
Status: assigned to needs_review

Trac:
Owner: teor to N/A
Status: needs_review to assigned

I asked Neel for the revisions on tor-dev

Trac:
Reviewer: dgoulet to dgoulet, teor
Status: assigned to needs_revision

New PR is here: https://github.com/torproject/torspec/pull/87

Please review this.

Trac:
Status: needs_revision to needs_review

Some comments.

What we need is asn or/and nickm to have a look at this since they can tell us if this change is inline with the Guard subsystem behaviors.

Trac:
Status: needs_review to needs_revision

Assigning to asn or nickm for review.

Trac:
Status: needs_revision to needs_review
Reviewer: dgoulet, teor to asn, nickm

This proposal needs some minor revisions before it will be ready for review.

Trac:
Status: needs_review to needs_revision

See https://lists.torproject.org/pipermail/tor-dev/2019-August/013959.html for details.

Deferring various tickets from 0.4.2 to Unspecified.

Trac:
Keywords: N/A deleted, 042-deferred-20190918 added
Milestone: Tor: 0.4.2.x-final to Tor: unspecified

Let's just do this all in #29801 (moved).

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed

mentioned in issue #29801 (moved)

moved to tpo/core/tor#31039 (closed)