Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #31075

Closed (moved)
Open
Opened Jul 03, 2019 by Alex Catarineu@acat

Consider dropping browser patch for 26353

I think the patch for #26353 (moved) is not strictly needed, since the speculative connections are blocked when a proxy is configured (here: https://github.com/mozilla/gecko-dev/blob/esr60/netwerk/base/nsIOService.cpp#L1621, and same in 68). So while the speculative requests can be seen in torbutton domain-isolator, they should be dropped before they reach tor client.

I tested by changing the torbutton code to not put all these to the --unknown-- catch-all circuit so that they could be tracked, and while I can see these in logs coming from the domain isolator, there are no corresponding open circuits in the Torbutton INFO: controlPort << getinfo circuit-status logs.

It's always possible that this might change in the future (according to the comments in that file, the reason why the speculative connections are not performed when there is a proxy do not seem so strong). So we might still want the current patch for #26353 (moved) just in case, I'm not sure.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#31075