Fix coverity failures in unit tests as of 19 August 2019

Other than #31451 (moved) and a deadcode issue in trunnel, our current "new" and "triaged" issues are all in the unit tests.

Let's fix them all, to keep our code quality up.

changed milestone to %Tor: 0.4.2.x-final

added actualpoints::0.1 component::core tor/tor dgoulet-merge milestone::Tor: 0.4.2.x-final owner::nickm points::0.1 priority::medium resolution::fixed reviewer::catalyst severity::normal status::closed type::defect labels

Trac:
Points: N/A to 0.5

It turns out there is only one of these: CID 1447292

Trac:
Points: 0.5 to 0.1

See branch bug31452 with PR at https://github.com/torproject/tor/pull/1239 .

Trac:
Actualpoints: N/A to 0.1
Status: assigned to needs_review

Trac:
Reviewer: N/A to catalyst

Replying to nickm:

See branch bug31452 with PR at https://github.com/torproject/tor/pull/1239 . Thanks! This looks good.

Trac:
Status: needs_review to merge_ready

Merged!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed
Keywords: N/A deleted, dgoulet-merge added

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#31452 (closed)