Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #31490
Closed (moved) (moved)
Open
Issue created Aug 22, 2019 by David Goulet@dgoulet🐼

hs-v3: Turns out the hs_ident circuit_type is not used

I stumble upon this while investigating #30200 (moved). My HS debugging showed up with circuit type set to INTRO for a rendezvous circuit.

In, one of the most insane function we have, circuit_get_open_circ_or_launch(), towards the end, we set the HS identifier of the open circuit:

          circ->hs_ident =
            hs_ident_circuit_new(&edge_conn->hs_ident->identity_pk,
                                 HS_IDENT_CIRCUIT_INTRO);

... notice, we only use INTRO type, never the RENDEZVOUS one.

Further looking at it, it appears that the hs_ident->circuit_type field is just pointless. Client will only set the INTRO (see code above) and the service will properly set both. But then after that, it is just never used.

I propose we either remove it or fix the client side because if we ever rely on that field, it is of today really wrong client side.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking