undefined (#18515)

The repo: https://github.com/malekbr/tor The branch: refactor_parsing_rend

Trac:
Username: malekbr

Trac:
Username: malekbr
Status: new to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.2.9.x-final

Food for thoughts. So I like this move in general. Although, I think we could do better. Those parsing functions are for the HS descriptor so how about we create a renddesc.{c|h} file and move parsing + encoding functions there (and maybe all related functions to descriptor)?

I fear that rendparse.c (name) doesn't have the extra indication that this is for descriptor. We are not parsing HS cells in there for instance.

(This is the approach we took for next generation hidden service that is have hs_descriptor.{c|h} for all descriptor related API/ABI.)

Trac:
Status: needs_review to needs_information
Keywords: N/A deleted, tor-hs added

Another data point voting for this. parsecommon.{c|h} are needed for proposal 224 that is using the parsing ABI/API from routerparse.c for an HS descriptor and for this we need it out of the .c

FYI, I have a commit in my dev branch for this. It's needed for #17238 (moved) that is implementing the HSDir support for 224. (Changing parent ID to it)

Trac:
Parent: N/A to #17238 (moved)
Owner: malekbr to dgoulet
Status: needs_information to accepted
Sponsor: N/A to SponsorR-must

Trac:
Points: N/A to small

For context, dgoulet meant the dc746ac57 commit in his ticket18571_029_01 branch (from #18571 (moved)).

        src/or/onion_tap.c                              \
        src/or/transports.c                             \
+       src/or/parsecommon.c                    \
        src/or/periodic.c                               \
        src/or/policies.c                               \
[...]
        src/or/transports.h                             \
+       src/or/parsecommon.h                    \
        src/or/periodic.h                               \

Interesting choice of whitespacing here. :)

For the rest of it: what's the best git command I should be using to see just the actual changes in the lines? Or is that harder than it should be?

Replying to arma:

For the rest of it: what's the best git command I should be using to see just the actual changes in the lines? Or is that harder than it should be?

Surely you don't mean diffstat.

If you mean "inline diff" (what's the actual name for this?), then you can try --color-words in git. But this breaks the structure of the line, so I prefer to pipe the diff output into Jeff King's diff-highligh script: $ git diff --color | diff-highlight

You can find diff-highlight in git's contrib/ directory.

Trac:
Points: small to 1

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

Trac:
Keywords: N/A deleted, nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-final to Tor: 0.3.0.x-final

Merged as part of #17238 (moved) in commit e8c12175.

Trac:
Status: accepted to closed
Resolution: N/A to fixed

Activity