Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #31594
Closed (moved) (moved)
Open
Created Sep 03, 2019 by teor@teor

Close all the log fds before aborting

We should close the sigsafe_log_fds before abort(), so that we are less likely to lose log lines in the fd buffers.

Here are the abort() users:

  • tor_abort_()
  • crash_handler()
  • format_number_sigsafe()
  • raw_assert()
  • raw_assert_unreached_msg()
  • trunnel_abort()

We could:

  • define a raw_abort() function that closes the fds
  • use it instead of abort()
  • #define trunnel_abort() as raw_abort()
  • update our C linter to require raw_abort() instead of abort()
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking