Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #32334

Closed (moved)
Open
Opened Oct 29, 2019 by eighthave@eighthave

do not throw enable_tool_name_check error when compiling for Android and iOS

This check only fails when building for Android and iOS, it does not do something useful there. So when compiling for Android or iOS, it should be disabled by default. Or perhaps even better: it should only be enabled on platforms where it is useful. The Guardian Project, Thali, and Briar Android builds have always used --disable-name-tool-check. The iCepa Tor.framework also does.

Some examples:

  • LarryBitcoin: https://trac.torproject.org/projects/tor/ticket/31552#comment:4
  • n8fr8: https://trac.torproject.org/projects/tor/ticket/31301#comment:2
  • iCepa Tor.framework: https://github.com/iCepa/Tor.framework/blob/30480101b3bd2166baced913347fc8bb7392b3da/Tor/tor.sh#L139
  • tor-android: https://github.com/guardianproject/tor-android/blob/0830c87a29ea197ecd9a0b5aee7d9a4fb88dce25/external/Makefile#L271
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#32334