Phase 1: Stop compiling "acting as a directory cache" in --disable-module-relay

We want to stop compiling the code that makes tor act as a directory cache, when the relay module is disabled.

(We already disable DirPort and DirCache, so the functionality is not available.)

At each stage, we should work to minimize layer-violations: there should generally not be calls from src/core/ into relay-specific code, and we should plan to refactor as needed to minimize them. We can reduce layer violations in parallel with the above.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #31851 (moved)

added 043-can actualpoints::.1 component::core tor/tor milestone::Tor: 0.4.3.x-final network-team-roadmap-november owner::nickm parent::31851 points::1 priority::medium resolution::implemented reviewer::teor severity::normal sponsor::31-can status::closed tor-design type::enhancement labels

Trac:
Actualpoints: N/A to .1
Status: new to accepted
Owner: N/A to nickm

This went much faster than I had expected. See branch ticket32487 with PR at https://github.com/torproject/tor/pull/1644

Trac:
Status: accepted to needs_review

Trac:
Reviewer: N/A to teor

Looks good overall, but there are a few things that need fixing.

I also had some design questions.

Please see my comments on the pull request.

Trac:
Status: needs_review to needs_revision

I've made the requested changes, and moved the dirclient-mode-checking functions in to the dirclient module.

Trac:
Status: needs_revision to needs_review

Oh, wait, I still have one more to do.

Trac:
Status: needs_review to needs_revision

Okay, now I've covered the last one. Please let me know if I missed anything?

Trac:
Status: needs_revision to needs_review

(Fwiw, I expect this to conflict in include.am files with #32137 (moved) on merge; I'm happy to resolve the conflicts when we do the merge.)

tag all currently needs_review tickets with 043-can. (Since there's code before the feature freeze, maybe we can take it.)

Trac:
Keywords: N/A deleted, 043-can added

Code changes look good, there's one minor mistake in a comment.

But CI is failing when we disable relay, so there's something wrong here.

Trac:
Status: needs_review to needs_revision

Whoops! I've pushed a couple more fixups. I'll keep an eye on CI.

Trac:
Status: needs_revision to needs_review

Okay, it looks like CI is failing because of the merge conflict with #32137 (moved) I mentioned above.

I've made a new branch ticket32487_squashed_and_merged. The PR is https://github.com/torproject/tor/pull/1669

the updates branch passes, let's merge.

Trac:
Status: needs_review to merge_ready

Merged it!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 8h

added 48m of time spent

mentioned in issue #31851 (moved)

moved to tpo/core/tor#32487 (closed)