Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33283

Closed (moved)
Open
Opened Feb 12, 2020 by boklm@boklm

Add caching for the exec function in rbm

In a mail to tbb-dev, dcf mentioned that while building tor-browser, a lot of time is spent in rbm: https://lists.torproject.org/pipermail/tbb-dev/2020-February/001045.html

I think an easy way to improve this is by caching the result from the exec() template function. We use it for example with the line version: '[% c("abbrev") %]' which runs something like exec("git log -1 --format=%h"), which then runs a git checkout before running the git log command. The version value is used in filenames, and build_id, which are then used in a lot of places, but with no caching we end up doing a lot of calls the same git checkout and git log commands. The switch to pion which added a lot of go projects each with their git repository probably made this issue more visible.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33283