Upgrade Rust To Use Android NDK 20
Upgrade rust to use latest toolchain
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
Trac:
Parent Ticket: #33184 (moved)- Author
gcc is no longer supported in the Android NDK so I moved this to use clang.
Rust was no longer able to find the ar command. This occurs since the clang executable has the android API level in the file name.
i686-linux-android29-clang
Rust tries to use the name of the clang command, with API, to infer the target as
i686-linux-android29-ar
However, ar is
i686-linux-android-ar
I add the correct ar in options to solve this issue.
There is an oddity for arm, which doesn't occur in other platform variants. As ar is
arm-linux-androideabi-ar
while clang is
armv7a-linux-androideabi29-clang
so arm ar doesn't contain any portion of the correct host. So the options are a little different here.
https://github.com/sisbell/tor-browser-build/commits/bug-33833
Trac:
Status: new to needs_review
Actualpoints: N/A to .5 Trac:
Keywords: N/A deleted, TorBrowserTeam202004R addedThe patch has at least a typo which breaks the aarch64 build. We should bump rust to the latest version used, too (see: #33557 (moved) for the requirements).
Trac:
Keywords: TorBrowserTeam202004R deleted, TorBrowserTeam202004 added
Status: needs_review to needs_revision
Parent: #33184 (moved) to #33626 (moved)Trac:
Sponsor: N/A to Sponsor58-mustTrac:
Owner: tbb-team to gk
Status: needs_revision to assigned
Cc: sysrqb, boklm to tbb-team
Parent: #33626 (moved) to #33184 (moved)
Keywords: TorBrowserTeam202004 deleted, GeorgKoppen202005, TorBrowserTeam202005 added
Reviewer: N/A to sysrqbMoving tickets to high prio.
Trac:
Priority: Medium to HighThis is ready for review on my branch
fenix_toolchain
(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=fenix_toolchain&id=c2c988bec9242fece4287dafdcf90f63cdb3b7f1).Trac:
Keywords: Android, TorBrowserTeam202005 deleted, TorBrowserTeam202005R, tbb.rbm added
Status: assigned to needs_reviewI believe I have a slightly cleaner approach in
fenix_toolchain3
. I am currently testing therust
compilation.Trac:
Keywords: TorBrowserTeam202005R deleted, TorBrowserTeam202005 added
Summary: Upgrade Rust To Use Android NDK 21 to Upgrade Rust To Use Android NDK 20
Status: needs_review to needs_revisionReplying to gk:
I believe I have a slightly cleaner approach in
fenix_toolchain3
. I am currently testing therust
compilation.Here it is, up for review: https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=fenix_toolchain3&id=d8ceb11db2e1f5cdb4744d2fc84994ad898a3f8e.
Trac:
Keywords: TorBrowserTeam202005 deleted, TorBrowserTeam202005R added
Status: needs_revision to needs_reviewMoving review tickets.
Trac:
Keywords: TorBrowserTeam202005R deleted, TorBrowserTeam202006R added- Trac added 4h of time spent
added 4h of time spent
- Trac mentioned in issue #33184 (moved)
mentioned in issue #33184 (moved)