Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33899

Closed (moved)
Open
Opened Apr 14, 2020 by teor@teor

Allow IPv6 addresses to be canonical

In #17604 (moved), we allowed IPv6 connections to set is_canonical_to_peer. But we did not let them set is_canonical.

So channel_tls_process_netinfo_cell() handles IPv6 addresses, but connection_or_check_canonicity() does not.

This inconsistency could be one cause of the logging issues in #24841 (moved).

We should allow IPv6 connections to be canonical. We should also do some cleanup of the related connection address logging in #33898 (moved).

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.4.x-final
Milestone
Tor: 0.4.4.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33899