Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #34368

Closed (moved)
Open
Opened Jun 03, 2020 by Georg Koppen@gk

Improve authenticode-signing script to better check for a signature

Our current authenticode-signing.sh script checks two things at the moment:

  1. Whether a .exe is still unsigned
  2. Whether removing a signature (using osslsigncode remove-signature) is producing the same SHA-256 sum as outlined in the SHA-256 sums file.

If both conditions hold it concludes that the bundles are properly signed.

There are ways for improvement here. While I think it's important to check that removing the signature provides the expected unsigned SHA-256 we could try to check the signature directly.

osslsigncode verify -require-leaf-hash comes to mind. We should investigate, though, how that behaves in case of truncated/broken signatures or no signatures at all.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#34368