Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #4710

Closed (moved)
Open
Opened Dec 13, 2011 by Mike Perry@mikeperry

Tor does not convert TCP socket exhaustion to END_STREAM_REASON_RESOURCELIMIT

Moritz has reported the appearance of warns to the effect of "[warn] Error binding network socket: Address already in use" recently as a result of the PID feedback experiment. We could implement a feedback cap for nodes that hit this exhaustion, if we could detect it using stream end reasons (#4709 (moved)).

However, in errno_to_stream_end_reason(), it looks like Tor does not have a case covering "Address already in use" (EADDRINUSE and possibly also EADDRNOTAVAIL), which seems to be the errno Moritz's Ubuntu server is choosing when it runs out of TCP source ports.

I'd add these cases myself, but I am not sure if it should be an E_CASE or S_CASE, and I'm also not sure if the TCP source port exhaustion errno is always the same EADDRINUSE across all platforms, or just on Linux. It seems like a weird choice to me.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.3.x-final
Milestone
Tor: 0.2.3.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#4710