Clients send NETINFO with time

While implementing tordate, I noticed that Tor clients send NETINFO cells to servers with their time.

I believe that this is to spec but that both the implementation and the spec are wrong. A client should simply fill the time field out with zeros. We already send zero as the address as a client, we should also send zero as the time stamp.

changed milestone to %Tor: 0.2.4.x-final

added component::core tor/tor milestone::Tor: 0.2.4.x-final parent::9767 priority::medium prop222 resolution::implemented status::closed tor-client type::defect labels

Trac:
Component: - Select a component to Tor Client

You should base your branch off of maint-0.2.1

Trac:
Milestone: N/A to Tor: 0.2.1.x-final

This will also require a spec patch, and a quick review of the netinfo parse code.

(Bridges should also do it too (so that we don't open a new distinguisher as in #4348 (moved)).)

Replying to asn:

(Bridges should also do it too (so that we don't open a new distinguisher as in #4348 (moved)).)

Good idea. Looks like that fix only went into 0.2.3 also. Wonder if that means we should re-target this one.

wanoskarnet seems to have a point here:

10:53 < wanoskarnet> What are you trying to do with #4852? Did you know that guard can read client's timestamp from TLS client hello anyway?

No reason not to remove one of the cases where we leak it.

Trac:
Milestone: Tor: 0.2.1.x-final to Tor: 0.2.3.x-final

arma, any reason you moved this to 0.2.3.x-final?

ioerror, can I expect the spec patch from you some time before the merge deadline?

Trac:
Keywords: N/A deleted, small-feature added

Trac:
Status: new to needs_review

moved it to 0.2.3.x because a) that's where we did the other fixes in that function, for bridge enumeration, and b) the tls handshake gives away exact time so it's not like this is worth bothering stable users with.

oh hm. Is there actually code here? If not, why is this needs_review?

Ah, I guess there isn't code yet. Throwing this into 0.2.4.x; it's not urgent, since (as noted above) the information is already exposed in the TLS clientrandom

Trac:
Status: needs_review to assigned

Trac:
Milestone: Tor: 0.2.3.x-final to Tor: 0.2.4.x-final

Trac:
Keywords: small-feature deleted, small-feature maybe-proposal added

Trac:
Keywords: small-feature maybe-proposal deleted, small-feature maybe-proposal tor-client added

Trac:
Component: Tor Client to Tor

Replying to asn:

wanoskarnet seems to have a point here:

{{{ 10:53 < wanoskarnet> What are you trying to do with #4852 (moved)? Did you know that guard can read client's timestamp from TLS client hello anyway? }}}

Created #7277 (closed) for it.

Trac:
Cc: arma nickm to arma, nickm, adrelanos@riseup.net

Still worth doing if we ever approach #7277 (closed)

Trac:
Milestone: Tor: 0.2.4.x-final to Tor: unspecified

Folks seem interested in this for 0.2.5.x.

Trac:
Keywords: small-feature maybe-proposal tor-client deleted, small-feature maybe-proposal tor-client easy added
Status: assigned to new
Milestone: Tor: unspecified to Tor: 0.2.5.x-final

Trac:
Keywords: small-feature maybe-proposal tor-client easy deleted, tor-client prop222 added
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.4.x-final
Parent: N/A to #9767 (moved)

There is a patch for this as part of #9767 (moved)

Trac:
Status: new to needs_review

The #9767 (moved) patch to implement proposal 222 is now merged.

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

mentioned in issue #7277 (closed)

mentioned in issue #9798 (moved)

mentioned in issue #17911 (moved)

moved to tpo/core/tor#4852 (closed)

mentioned in issue tpo/core/tor#17911 (closed)