Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #5646

Closed (moved)
Open
Opened Apr 18, 2012 by George Kadianakis@asn

Many functions log before checking for proto violation

rend_mid_establish_intro():

  log_info(LD_REND,
           "Received an ESTABLISH_INTRO request on circuit %d",
           circ->p_circ_id);

rend_mid_introduce():

  log_info(LD_REND, "Received an INTRODUCE1 request on circuit %d",
           circ->p_circ_id);

rend_mid_establish_rendezvous():

  log_info(LD_REND, "Received an ESTABLISH_RENDEZVOUS request on circuit %d",
           circ->p_circ_id);
< [censored]> check proto was places exactly to filter that. some one encodes something before it, that is bug.
< asn> check proto?
< asn> ye, rend_mid_rendezvous() does the stupid encoding thing before checking for proto violation, like you said.
< [censored]> most of that funcs is wrong.
< [censored]> some logs about recved stuff. why if it wrong cell in wrong circ?
< asn> then you get two logs
< asn> one that says "received..." and another that says "rejecting..." 
< asn> in the case of rend_mid_establish_intro() for example
< [censored]> why? another funcs can't report about recved cell without encode. no one funcs should log anything before checks.
< asn> ok. i'm more than fine with "checks first, everything afterwards (including logs)"
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.3.x-final
Milestone
Tor: 0.2.3.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#5646