no feedback when clicking "Use a New Identity"

0.2.17 on OSX

There is no feedback whatsoever when clicking the "Use a New Identity" button. The button doesn't "click" indicating anything has happened, there is no message that a circuit has been created, no way to know that the users desire has been carried out and subsequent uses of Tor will come from a different exit.

added component::archived/vidalia owner::sebb priority::low resolution::fixed status::closed type::defect version::vidalia 0.2.17 labels

Trac:
Component: - Select a component to Vidalia
Owner: N/A to chiiph

If you don't have growl or something similar, no, you won't see any visible feedback. This is because of the custom clickable label implementation, which is left out in alpha.

I'm going to leave this open for now, but it is not something that I will focus on since Vidalia alpha will become stable in not so long. I will, on the other hand, accept patches that fix this.

Trac:
Priority: normal to minor

I can take care of this. Which one should it be - add some kind of "click" indicator to VCLickLabel class (like different background color between press and release events), or a message in status bar, or both ?

Trac:
Username: sebb
Status: new to assigned
Cc: N/A to chiiph, sebb
Owner: chiiph to sebb

The message in the status bar will be tricky, because we are assuming that the user does not have something like growl.

I think just visual feedback from the vclicklabel is enough for this. Have in mind that the alpha already solves this, so the fix for the current stable shouldn't be too time consuming.

https://github.com/sebthestampede/vidalia/commit/ba6ccee035984ea73227051480189cb0c86398c0 branch: 5766_clicklabel (based on master)

Trac:
Username: sebb
Status: assigned to needs_review

Have you seen the flashing code for VClickLabel? Now that I come to think about it, may be we can merge the idea of having a pressed VClickLabel with a flashing one. What do you think?

I haven't tested your branch yet, in terms of code it looks good.

Trac:
Status: needs_review to needs_revision

you mean something like this ? https://github.com/sebthestampede/vidalia/commit/7c25ed518387ec31df516af1fe98ef121beb0f56 I think it looks better now with flashing.

Trac:
Username: sebb
Status: needs_revision to needs_review

Looks good, merged!

It'll be out with 0.2.18. Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed