Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Matthew Finkel@sysrqb

read_from_old_location is set twice in router_reload_router_list_impl

The second mutation appears to exist so that the conditional above it can exist. Is there a reason to check the return value?

read_from_old_location = 1;
log_notice(LD_DIR, "Couldn't read %s; trying to load routers from old "
           "location %s.", fname, altname);
if ((store->mmap = tor_mmap_file(altname)))
  read_from_old_location = 1;
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information