Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #6872

Closed (moved)
Open
Opened Sep 17, 2012 by Damian Johnson@atagar

'bwweightscale' pram missing from spec

The 'bandwidth-weights' attribute mentions that its values are divided by the 'bwweightscale' param which defaults to 10000 (I'm not sure what meaning "BW_WEIGHT_SCALE" has - guess it's the name of the constant in tor's codebase?)...

https://gitweb.torproject.org/torspec.git/blob/HEAD:/dir-spec.txt#l1482

The network status document's "params" section should include 'bwweightscale' and the default value.

https://gitweb.torproject.org/torspec.git/blob/HEAD:/dir-spec.txt#l1228

On a side note it's pointless for 'bandwidth-weights' to say that the entries are sorted. The above shows the order that entries must appear in.

I'm assuming that new "Wxx=" values are invalid since the spec explicitly lists what it contains and makes no allowances for new ones. If this is incorrect then we should fix that too.

Cheers! -Damian

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.4.x-final
Milestone
Tor: 0.2.4.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#6872