Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #7263

Closed
Open
Created Oct 30, 2012 by Trac@tracbot

test.check_whitespace.get_issues not being used correctly.

This checkin expanded the scope of the check_whitespace function https://gitweb.torproject.org/stem.git/commit/c1450e440e388295a329e84b3e935bf86f88e673

However the arg passed can only be a path, not a filename so the 3rd line of this checkin has no effect. https://gitweb.torproject.org/stem.git/blobdiff/c52042c44b5a157dceb6013743fdea40bbc3f52c..c1450e440e388295a329e84b3e935bf86f88e673:/run_tests.py

A easier approach would be to scan all python files in the project? I've made this change here: https://github.com/eoinof/stem/commit/5c64a755590a275265665cf082a2fc928ac0972b#run_tests.py

And fixed 2 whitespace issues in run_tests.py here: https://github.com/eoinof/stem/commit/b458b667913f4b4e89fb1d11afea68a15fef3f84#run_tests.py

Trac:
Username: eoinof

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking