rend_service_introduce() doesn't notice if the rendezvous point is on 127.0.0.1
An anonymous person on irc just pointed out to me that rend_service_introduce() has no checks for whether the introduce2 cell specifies a private address.
I've only looked at it cursorily, but I don't think it's the end of the world. The relay that is asked to extend to this private address will probably have ExtendAllowPrivateAddresses set to 0, and will refuse.
Perhaps it will cause the hidden service to keep trying to reach the rendezvous point (wasting lots of circuits), but that could be induced by telling it a public address that doesn't work too.
Anything else scary? Worth fixing anyway I guess.