Explain relay flags in detail view using tooltips

Personally, having known about Tor for some time, I still didn't know what all of the flags meant.

Using https://gitweb.torproject.org/torspec.git/blob/HEAD:/dir-spec.txt#l1768 as my guide I wrote some descriptions and have them display as a tooltip when you hover over each flag in the detail view.

The work was done in https://github.com/f3ndot/torproject-atlas/compare/explain-relay-flags and attached is the patch file.

Trac:
Username: f3ndot

added component::metrics/relay search description flag flags owner::irl priority::medium reporter::f3ndot resolution::fixed severity::normal status::closed tooltip type::enhancement labels

Trac:
Username: f3ndot

explain-relay-flags.patch

Trac:
Username: f3ndot

Trac:
Username: f3ndot
Status: new to needs_review

Thanks for the patch! I moved the discussion of phrasings to StackExchange, because I can't really say what relay operators find easiest to understand. Let's wait a few days for responses there and then apply the (possibly modified) patch. Thanks!

Trac:
Status: needs_review to needs_information

I appreciate the SE post, those phrases were best-effort guesses :-)

Trac:
Username: f3ndot

See also #7939 (moved) which I just closed as near duplicate of this ticket.

Trac:
Severity: N/A to Normal
Sponsor: N/A to N/A
Reviewer: N/A to N/A

Trac:
Status: needs_information to accepted
Owner: f3ndot to irl

I updated the patch for the current atlas website version and used the texts from the link in the comment in #7939 (moved). Here's the patch:

https://github.com/RaphaelBergmann/atlas/commit/ef7b682fc12223193efff2bebe8538aad3bb149d

(I also prepared the flag "NoEdConsensus" which was in the documentation, but has not yet been implemented on Atlas.)

Trac:
Username: RaBe
Status: accepted to needs_review

This doesn't seem to render correctly in Firefox ):

I'll attach a screenshot. I'm using Firefox ESR 45.4.0.

I get $.fn.tooltip is not defined in the console output.

Trac:
Status: needs_review to assigned
Owner: irl to RaBe

Trac:

Rendering of the flag tooltips in Firefox ESR 45.4.0

It was the "popover" function that threw that error and stopped all following JS to work (Firefox only), so I removed it and then replaced the popovers with tooltips so we're not losing any functionality. Also, I fixed a small issue with the search table, where tooltips were not working properly when filtering results or changing the "show entries" value.

https://github.com/RaphaelBergmann/atlas/compare/task-9913

Trac:
Username: RaBe
Owner: RaBe to irl

Trac:
Username: RaBe
Status: assigned to needs_review

The fixes look good, but I can't merge that. You'll need to rebase the commits against the current master branch of https://gitweb.torproject.org/atlas.git. For example, that branch has 5 commits titled "Inserted zero width space character to wrap fingerprint line on smaller displays".

Whenever starting on a new ticket, please checkout master, pull to have the latest commits from the git.tpo repo, then branch, and rebase against the latest from git.tpo before adding a patch to the ticket.

This helps with testing as the patch is as close as possible to based on the latest sources, and also helps with merging and keeping a clean history in the git repository.

Trac:
Owner: irl to N/A
Status: needs_review to assigned

Trac:
Status: assigned to needs_revision

Oh, I'm sorry. So here's the new patch (for some reason I did not manage to "fix" the other branch...):

https://github.com/RaphaelBergmann/atlas/compare/task-9913-new

Trac:
Username: RaBe
Owner: N/A to irl
Status: needs_revision to assigned

Trac:
Username: RaBe
Status: assigned to needs_review

LGTM. Merged.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #20382 (moved)

mentioned in issue #21364 (moved)

mentioned in issue #21398 (moved)