Fixes #40163

Signed-off-by: David Goulet <dgoulet@torproject.org>

When calling `circpad_send_padding_cell_for_callback()`, the flag
`is_padding_timer_scheduled` was not resetted to 0 which caused an issue
in the circpad simulator.
This commit fixes this problem.

Fixes #32671.

Guinness authored 4 years ago and Nick Mathewson committed 4 years ago

Tor does not follow redirects when bootstraping so we encountered an
error.

Fixes #40053

Also, explain why it's relevant for bootstrapping.

This is a comments-only patch.

We've been using it for years, and it seems to work just fine.  This
patch removes the option and its network parameter.

Part of #40139

Part of #40139, where I'm removing network parameters that we
shouldn't be looking at any longer.

Tor has a feature to preserve unrecognized state file entries in
order to maintain forward compatibility.  But this feature, along
with some unused code that we never actually removed, led to us
keeping items that were of no use to the user, other than at worst
to preserve ancient information about them.

This commit adds a feature to remove obsolete entries when we load
the file.

Closes ticket 40137.

Nick Mathewson authored 4 years ago and David Goulet committed 4 years ago

It's way too easy to have a warning in the middle of the configure
process that the user never notices.

David Goulet authored 4 years ago and Nick Mathewson committed 4 years ago

If at least one service is configured as a version 2, a log warning is emitted
once and only once.

Closes #40003

Signed-off-by: David Goulet <dgoulet@torproject.org>