Faster Than Light!

Not the whole story; machines still need to use this.

Does not require protover update, since this is just client-side.

Allows us to program machines that stay around after creation if circuit state
or purpose changes.

"ours" to avoid version bump.

Closes ticket 34446.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>

Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>

Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>

Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>

Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>

This tracking of the instantiation count should eliminate race conditions due
to starting and stopping machines rapidly. Now, we should no longer obey
STOP commands for previous machines.

("Ours" to avoid removal of .enable_practracker_in_hooks)

This field area was memset to 0 in old versions, which the code treats as
"match any machine instance", for backward compatibility without a protover
bump.

Per <https://trac.torproject.org/projects/tor/ticket/34381>, these
contrib scripts were generated by older versions of Tor and shellcheck
will throw warnings if they still exist.

Alexander Hansen Færøy authored 4 years ago and Nick Mathewson committed 4 years ago

This patch makes sures that AppVeyor upgrades its Pacman (the package
manager) before installing the Tor dependencies.

See: https://bugs.torproject.org/34384