-
- Downloads
Remove fgets() compatbility function and related tests.
This patch removes the `tor_fgets()` wrapper around `fgets(3)` since it is no longer needed. The function was created due to inconsistency between the returned values of `fgets(3)` on different versions of Unix when using `fgets(3)` on non-blocking file descriptors, but with the recent changes in bug #21654 we switch from unbuffered to direct I/O on non-blocking file descriptors in our utility module. We continue to use `fgets(3)` directly in the geoip and dirserv module since this usage is considered safe. This patch also removes the test-case that was created to detect differences in the implementation of `fgets(3)` as well as the changes file since these changes was not included in any releases yet. See: https://bugs.torproject.org/21654
Showing
- changes/bug20988 0 additions, 4 deletionschanges/bug20988
- src/common/compat.c 0 additions, 39 deletionssrc/common/compat.c
- src/common/compat.h 0 additions, 2 deletionssrc/common/compat.h
- src/or/dirserv.c 2 additions, 2 deletionssrc/or/dirserv.c
- src/or/geoip.c 1 addition, 1 deletionsrc/or/geoip.c
- src/test/test_util.c 0 additions, 111 deletionssrc/test/test_util.c
Loading
Please register or sign in to comment