Reset the added bootstrap tracking state introduced by ticket 27169.
Fixes bug 28524; bugfix on 0.3.5.1-alpha.

Alexander Hansen Færøy authored 6 years ago and Nick Mathewson committed 6 years ago

To succesful compile tor-print-ed-signing-cert.exe on Windows we
sometimes need to include the @TOR_LIB_GDI@ library.

See: https://bugs.torproject.org/28485

"ours" merge to avoid taking 25573 and 27686 again.

"ours" merge to avoid duplicating conflict resolution in merge of 24104

Resolved conflicts with the 26269 fix in 015fcd0e.

"ours" merge to avoid the 0.3.3 version of #27550.

Documentation for 28399, 28454, and previous fixes.

The mingw zstd from MSYS2 doesn't come with a pkg-config file.

Fixes 28454 on Tor 0.3.4.1-alpha.

Fixes 28399 on 0.3.4.1-alpha.

Stop installing MSYS2 packages.
We're compiling for mingw, so we only need mingw packages.

Run pacman in verbose mode.

Explicitly install pkg-config and xz, to future-proof our builds.

Diagnostics for 28399.

David Goulet authored 6 years ago and Nick Mathewson committed 6 years ago

In conn_close_if_marked(), we can decide to keep a connection open that still
has data to flush on the wire if it is being rate limited on the write side.

However, in this process, we were also looking at the read() side which can
still have token in its bucket and thus not stop the reading. This lead to a
BUG() introduced in 0.3.4.1-alpha that was expecting the read side to be
closed due to the rate limit but which only applies on the write side.

This commit removes any bandwidth check on the read side and simply stop the
read side on the connection regardless of the bucket state. If we keep the
connection open to flush it out before close, we should not read anything.

Fixes #27750

Signed-off-by: David Goulet <dgoulet@torproject.org>

Martin Kepplinger authored 6 years ago and Nick Mathewson committed 6 years ago

This avoids leaking memory in case libtorrunner's child() function fails.

Taylor Yu authored 6 years ago and Nick Mathewson committed 6 years ago

Make Doxygen work again after the 0.3.5 source tree moves.  Fixes bug
28435; bugfix on 0.3.5.1-alpha.

Clients have ignored the Named flag since 0.3.2.

Fixes bug 28441; bugfix on 0.3.2.1-alpha.