I'm about to mess with their lists of callbacks, and I don't want to
proliferate lists where we say "NULL, NULL, NULL, ..."

Nick Mathewson authored 5 years ago and teor committed 5 years ago

Our minimum version is now 0.2.9.5-alpha.  Series 0.3.0, 0.3.1,
0.3.2, 0.3.3, and 0.3.4 are now rejected.

Also, extract this version-checking code into a new function, so we
can test it.

Closes ticket 31549.

Also reject 0.3.5.0 through 0.3.5.6-rc as unstable.

We can't do this with the "options" argument yet, since several
places in the code change those right now.

These arguments were only used by options_validate, and are now
ignored even there.

Coccinelle doesn't understand the particular pattern of token
pasting we have going on here.

Use BUG() for coding errors, and `< 0` for error checks.

Fix to 31684.

Part of 31684.

AmreshVenugopal authored 5 years ago and teor committed 5 years ago

- Allows control port to read microdesc consensus using:
GETINFO dir/status-vote/microdesc/consensus

add: Helper function `getinfo_helper_current_consensus`
test: check if GETINFO commands return expected consensus data.

Resolves 31684.

Part of 32123.

Part of 32123.

proxy_mode() was in routermode.[ch], but it's actually a client
mode. Move it into client/proxymode.[ch].

Part of 32123.

This patch removes an overly strict tor_assert() and an ignorable BUG()
expression. Both of these would trigger if a PT was unable to configure
itself during startup. The easy way to trigger this is to configure an
obfs4 bridge where you make the obfs4 process try to bind on a port
number under 1024.

See: https://bugs.torproject.org/31091

Tobias Stoeckmann authored 5 years ago and Alexander Hansen Færøy committed 5 years ago

In case of error, a negative value will be returned or NULL written into
first supplied argument.

This patch uses both cases to comply with style in the specific files.

A tor_vasprintf error in process_vprintf would lead to a NULL dereference
later on in buf_add, because the return value -1 casted to size_t would
pass an assertion check inside of buf_add.

On the other hand, common systems will fail on such an operation, so it
is not a huge difference to a simple assertion. Yet it is better to
properly fail instead of relying on such behaviour on all systems.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>

These need to start with /**, not /*.

These are yet more that were not made with "/**"

Previously some of the comments here used /*.

Including a file in the middle of a declaration seems to confuse
Doxygen, and Coccinelle doesn't much like it either.l

In 8 places, our \file declarations didn't match the actual files
they were in.

Found by coverity CID 1454769.

There were a second possible leak that is also fixed in this commit.

Fixes #32063

Signed-off-by: David Goulet <dgoulet@torproject.org>

David Goulet authored 5 years ago and Nick Mathewson committed 5 years ago

Found by Coverity.

Fixes #31682

Signed-off-by: David Goulet <dgoulet@torproject.org>