Style:
  - We end our types with _t.
  - Use 'static' to declare functions that only exist in a single
    module.

Correctness:
  - Many tt_...() macros can invoke "goto done;" -- we need to make
    sure that all the variables that could get freed are initialized
    before any "goto done" is hit, or else we might free an
    uninitialized variable.

maurice_pibouin authored 4 years ago and Nick Mathewson committed 4 years ago

   [This is a squashed patch for ticket 7193, based on taking a "git
   diff" for the original branch, then applying it with "git apply
   -3".  I earlier attempted to squash the branch with "git rebase",
   but there were too many conflicts. --nickm]

This should also get feedback from @mikeperry.

Closes #40136

This will require feedback from @mikeperry, since these are a bit
subtle and I've likely mangled some of these.

Part of a fix for #40136.

This patch adds all the state file entries to the documentation, and
documents the ones that I understand well.

Fixes #40135

Signed-off-by: David Goulet <dgoulet@torproject.org>

These are:
  --disable-module-relay
  --disable-module-dirauth
  --enable-all-bugs-are-fatal
  --enable-nss

We already fixed these in #40099 and #40125.

This patch fixes #40126.  Bugfix on 0.2.8.1-alpha.