Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Oct 28, 2020
    • Nick Mathewson's avatar
      Revise fix for bug 32178 (spaces at end of log msg). · 51182252
      Nick Mathewson authored 
      The loop in the earlier patch would invoke undefined behavior in two
ways: First, it would check whether it was looking at a space before
it checked whether the pointer was in-range.  Second, it would let a
pointer reach a position _before_ the start of a string, which is
not allowed.

I've removed the assertion about empty messages: empty messages can
be their own warning IMO.

I've also added tests for this formatting code, to make sure it
actually works.
      51182252
    • Amadeusz Pawlik's avatar
      adds change file · 4520fbc0
      Amadeusz Pawlik authored and Nick Mathewson's avatar Nick Mathewson committed
      4520fbc0
    • Amadeusz Pawlik's avatar
      Removes trailing spaces in control event log · ec7a6757
      Amadeusz Pawlik authored and Nick Mathewson's avatar Nick Mathewson committed
      ec7a6757
    • David Goulet's avatar
      test: Missing tor_free() in metrics unit tests · 2edda444
      David Goulet authored 
      
Found by coverity:

  *** CID 1468664:  Resource leaks  (RESOURCE_LEAK)
  /src/test/test_metrics.c: 83 in test_config()
  77       tt_int_op(ret, OP_EQ, false);
  78
  79      done:
  80       SMARTLIST_FOREACH(ports, port_cfg_t *, c, port_cfg_free(c));
  81       smartlist_free(ports);
  82       or_options_free(options);
  >>>     CID 1468664:  Resource leaks  (RESOURCE_LEAK)
  >>>     Variable "err_msg" going out of scope leaks the storage it points to.
  83     }
  84
  85     static char _c_buf[256];
  86     #define CONTAINS(conn, msg) \
  87       do { \
  88         tt_int_op(buf_datalen(conn->outbuf), OP_EQ, (strlen(msg))); \

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      2edda444
  3. Oct 27, 2020
  5. Oct 26, 2020
  7. Oct 23, 2020
  9. Oct 22, 2020
    • Roger Dingledine's avatar
      Turn ConsensusParams into a Linelist · 00118355
      Roger Dingledine authored 
      Make it possible to specify multiple ConsensusParams torrc
lines.

Now directory authority operators can for example put the
main ConsensusParams config in one torrc file and then add to it
from a different torrc file.

Closes ticket 40164.
      00118355
  11. Oct 21, 2020
  13. Oct 20, 2020