Fix bridge exit warn

Closes #40884

See merge request tpo/core/tor!783

add sanity check in tor_memmem

Closes #40854

See merge request tpo/core/tor!785

don't warn for empty RecommendedServerVersion

Closes #40888

See merge request tpo/core/tor!787

juga authored 1 year ago and David Goulet committed 1 year ago

Allow "node_id" KeyValue without the dollar sign at the start of the
hexdigit in the BandwidthFiles, in order to easier database queries
combining Tor documents in which the relays fingerprint doesn't
include it.
Bugfix on all supported versions of Tor.

Closes #40891

forward-port the 0.4.8.x change stanzas

See merge request tpo/core/tor!784

it's believed most libc already have those, but just in case, it can't
hurt

somehow our release process is not moving these into git main

fix man page typos

See merge request tpo/core/tor!781

Signed-off-by: David Goulet <dgoulet@torproject.org>

The hs_metrics_failed_rdv() macro could pass a NULL value for the identity key
when a building circuit would end up in a failure path *before* the "hs_ident"
was able to be set which leading to this assert.

This was introduced in 0.4.8.1-alpha with the addition of rendezvous circuit
failure metrics for the MetricsPort.

This fixes TROVE-2023-006 for which its severity is considered high.

Signed-off-by: David Goulet <dgoulet@torproject.org>