Bug 732319. Fix leaks on CORS failures in imagelib. r=joe

a7d0a926 · Boris Zbarsky · ea8d2e3b · a7d0a926 · a7d0a926 · a7d0a926
Commit a7d0a926 authored 13 years ago by Boris Zbarsky
--- a/image/src/imgLoader.cpp
+++ b/image/src/imgLoader.cpp
@@ -1718,12 +1718,19 @@ NS_IMETHODIMP imgLoader::LoadImage(nsIURI *aURI,
    // request.
    nsCOMPtr<nsIStreamListener> listener = pl;
    if (corsmode != imgIRequest::CORS_NONE) {
+      PR_LOG(gImgLog, PR_LOG_DEBUG,
+             ("[this=%p] imgLoader::LoadImage -- Setting up a CORS load",
+              this));
      bool withCredentials = corsmode == imgIRequest::CORS_USE_CREDENTIALS;

      nsCOMPtr<nsIStreamListener> corsproxy =
        new nsCORSListenerProxy(pl, aLoadingPrincipal, newChannel,
                                withCredentials, &rv);
      if (NS_FAILED(rv)) {
+        PR_LOG(gImgLog, PR_LOG_DEBUG,
+               ("[this=%p] imgLoader::LoadImage -- nsCORSListenerProxy "
+                "creation failed: 0x%x\n", this, rv));
+        request->CancelAndAbort(rv);
        return NS_ERROR_FAILURE;
      }


--- a/image/test/crashtests/732319-1.html
+++ b/image/test/crashtests/732319-1.html
+<!DOCTYPE html>
+<img crossorigin src="data:a/a,">
--- a/image/test/crashtests/crashtests.list
+++ b/image/test/crashtests/crashtests.list
@@ -25,3 +25,4 @@ HTTP load delayedframe.sjs

 load 681190.html
 load 694165-1.xhtml
+load 732319-1.html