Skip to content
Snippets Groups Projects
  1. Sep 08, 2017
    • Steve Fink's avatar
      Bug 1400442 - Annotate MOZ_CrashPrintf, r=jonco · 2c2bec02
      Steve Fink authored
      --HG--
      extra : rebase_source : 0ea91eb0373a1b0c848ce7e97f43a2006c190f29
      2c2bec02
    • Steve Fink's avatar
      Bug 1400442 - Targeted annotation for static local array of member pointers in... · 5a2de7af
      Steve Fink authored
      Bug 1400442 - Targeted annotation for static local array of member pointers in LangGroupFontPrefs::Initialize, r=bhackett
      
      The code is
      
          void
          LangGroupFontPrefs::Initialize(nsIAtom* aLangGroupAtom)
          {
              nsFont* fontTypes[] = {
                  &mDefaultVariableFont,
                  &mDefaultFixedFont,
                  &mDefaultSerifFont,
                  &mDefaultSansSerifFont,
                  &mDefaultMonospaceFont,
                  &mDefaultCursiveFont,
                  &mDefaultFantasyFont
              };
      
              nsFont* font = fontTypes[3];
              font->size = 42;
          }
      
      'this' is known to be a safe pointer (exclusively owned by the current thread), so a pointer to one of its members is also safe. But the analysis can't track safety across all that, so I have a special-case annotation here that says that fontTypes[3] returns a safe pointer if and only if 'this' is safe.
      
      Note that all of those fields (eg mDefaultVariableFont) are nsFont structs, not pointers, so although you'd expect this to be one dereference away from a safe pointer's memory, it is not; assigning to font->size ends up being a write to some offset within the 'this' pointer, which is known to be safe here.
      
      --HG--
      extra : rebase_source : 60bf982911b8a66bc612cb5c7eeb04ec766ecf70
      5a2de7af
    • Steve Fink's avatar
      Bug 1400442 - Annotate atof as not doing any racy writes, r=me · c849aebb
      Steve Fink authored
      --HG--
      extra : rebase_source : 206bba89c68e8dc37c135fed03490282eff61d76
      c849aebb
  2. Aug 31, 2017
  3. Sep 16, 2017
  4. Aug 31, 2017
  5. Sep 01, 2017
  6. Aug 09, 2017
  7. Sep 08, 2017
  8. Sep 19, 2017
  9. Jun 11, 2017
    • Boris Zbarsky's avatar
      Bug 1401204 - Make nsIMultiplexInputStream not inherit from nsIInputStream. r=bkelly · 5c70c284
      Boris Zbarsky authored
      This is a preexisting issue that makes nsMultiplexInputStream multiple-inherit
      from nsIInputStream: once via nsIMultipartInputStream and once via
      nsIAsyncInputStream.  This causes problems once we end up with more multiplex
      streams that are async streams, because then some assingments to
      nsCOMPtr<nsIInputStream> start asserting.  This patch just removes the footgun
      by getting rid of the multiple inheritance.
      5c70c284
  10. Sep 19, 2017
  11. Sep 15, 2017
  12. Sep 19, 2017
  13. Sep 14, 2017
  14. Sep 19, 2017
Loading