Skip to content
Snippets Groups Projects
  1. Aug 21, 2017
  2. Aug 17, 2017
    • Nicholas Nethercote's avatar
      Bug 1390428 (part 9) - Remove nsXPIDLCString. r=erahm. · f582d96b
      Nicholas Nethercote authored
      This is straightforward, with only two notable things.
      
      - `#include "nsXPIDLString.h" is replaced with `#include "nsString.h"`
        throughout, because all nsXPIDLString.h did was include nsString.h. The
        exception is for files which already include nsString.h, in which case the
        patch just removes the nsXPIDLString.h inclusion.
      
      - The patch removes the |xpidl_string| gtest, but improves the |voided| test to
        cover some of its ground, e.g. testing Adopt(nullptr).
      
      --HG--
      extra : rebase_source : 452cc4a08046a1adb1a8099a7e85a1917de5add8
      f582d96b
    • Nicholas Nethercote's avatar
      Bug 1390428 (part 6) - Remove nsXPIDLCString class members. r=erahm. · 9160e1cb
      Nicholas Nethercote authored
      These are all straightforward except for InternalLoadEvent::mTypeHint, which
      requires a bit of care to preserve existing behaviour.
      
      --HG--
      extra : rebase_source : 9b152122b011cf49b9acccdc98b4693548b8bdd2
      9160e1cb
  3. Aug 16, 2017
  4. Sep 04, 2017
  5. Aug 16, 2017
  6. Aug 09, 2017
  7. Aug 01, 2017
    • Nicholas Nethercote's avatar
      Bug 1386103 (part 2) - Convert nsFixed[C]String uses to nsAuto[C]String. r=erahm. · 7512aa2d
      Nicholas Nethercote authored
      In all of these cases the fixed buffer has the same lifetime as the string
      object, so we can use nsAuto[C]String for simplicity.
      
      For the 128-length ones in dom/xul/ I just switched to the default of 64 for
      simplicity, because the choice of 128 didn't seem that important. (These code
      paths weren't hit when I started the browser and opened a few sites.)
      
      Finally, the patch also changes LoggingIdString to use
      nsAutoCStringN<NSID_LENGTH>, similar to NullPrincipalURI.
      7512aa2d
  8. Aug 08, 2017
    • Nicholas Nethercote's avatar
      Bug 1387381 - Remove nsXPIDLString local variables. r=erahm. · 1a6f1a62
      Nicholas Nethercote authored
      nsXPIDLStrings are marked as VOIDED upon initialization. Most of these local
      nsXPIDLString variables are immediately set via getter_Copies(), which will
      either assign a string value (using Adopt()) or do SetIsVoid(). These can be
      trivially converted to nsString, which will get the same treatment.
      
      The patch suitably converts the remaining nsXPIDLString local variable as well.
      
      --HG--
      extra : rebase_source : 5fff9f2c6844559198f601853f8db08564add7d5
      1a6f1a62
  9. Jul 06, 2017
  10. Jul 01, 2017
    • Nicholas Nethercote's avatar
      Bug 13766386 - Minimize uses of prmem.h. r=glandium. · 3e439bb4
      Nicholas Nethercote authored
      It's silly to use prmem.h within Firefox code given that in our configuration
      its functions are just wrappers for malloc() et al. (Indeed, in some places we
      mix PR_Malloc() with free(), or malloc() with PR_Free().)
      
      This patch removes all uses, except for the places where we need to use
      PR_Free() to free something allocated by another NSPR function; in those cases
      I've added a comment explaining which function did the allocation.
      
      --HG--
      extra : rebase_source : 0f781bca68b5bf3c4c191e09e277dfc8becffa09
      3e439bb4
  11. Jun 25, 2017
  12. Jun 20, 2017
  13. Jun 18, 2017
  14. Jun 25, 2017
  15. Jun 18, 2017
  16. May 09, 2017
  17. Aug 18, 2017
  18. Mar 22, 2017
  19. Apr 04, 2017
  20. Mar 07, 2017
  21. Aug 16, 2017
  22. Aug 09, 2017
  23. Jan 26, 2017
    • Nathan Froyd's avatar
      Bug 1276669 - part 4 - initialize RDF atoms in nsLayoutStatics; r=Pike · 436e287a
      Nathan Froyd authored
      This is not the cleanest code ever, but we need to move all static atom
      initialization prior to NS_SealStaticAtomTable to avoid the possibility
      of dynamic atoms being transmuted into static atoms.  We therefore need
      to open up an avenue for somebody else to initialize the atoms that RDF needs.
      436e287a
  24. Feb 27, 2017
  25. Jan 18, 2017
  26. Feb 09, 2017
  27. Dec 16, 2016
  28. Dec 23, 2016
    • Nicholas Nethercote's avatar
      Bug 1329827 (part 2) - Remove DEVMO_NAMESPACE_URI_PREFIX. r=pike. · cae27a47
      Nicholas Nethercote authored
      It's unused and the site it refers to no longer exists.
      
      --HG--
      extra : rebase_source : 910e7fc54a4ba4c124d1217d7618ad2b68b9258b
      cae27a47
    • Nicholas Nethercote's avatar
      Bug 1329827 (part 1) - Remove rdfISerializer. r=pike. · 219d02a9
      Nicholas Nethercote authored
      Neither Firefox nor Thunderbird use any of rdfISerializer,
      NS_RDFNTRIPLES_SERIALIZER_CID, and
      "@mozilla.org/rdf/serializer;1?format=ntriples".
      
      https://dxr.mozilla.org/addons/source/ shows three addons that use them, but
      only one does so meaningfully: ArchView. (The others mention them as part of
      long lists of XPCOM interfaces.) According to AMO, ArchView hasn't been updated
      since August 2008, it has only 153 users, it doesn't work in Firefox 53. Also,
      judging from the code, rdfISerializer is only be used as part of debugging the
      addon itself. So I think that use can be ignored.
      
      This patch removes them. It also removes rdfTriplesSerializer.cpp.
      
      --HG--
      extra : rebase_source : faae5021ea9b58edf9d8f8b39ddd1551425544fc
      219d02a9
  29. Dec 09, 2016
  30. Dec 12, 2016
  31. Jan 05, 2017
  32. Nov 05, 2016
  33. Nov 04, 2016
Loading