Skip to content
Snippets Groups Projects
  1. Sep 20, 2017
  2. Sep 19, 2017
  3. Sep 18, 2017
  4. Sep 17, 2017
  5. Sep 16, 2017
  6. Sep 15, 2017
  7. Sep 14, 2017
  8. Sep 15, 2017
  9. Sep 13, 2017
  10. Sep 15, 2017
  11. Sep 14, 2017
    • Ted Mielczarek's avatar
      bug 1399877 - Globally define DLL_PREFIX/DLL_SUFFIX. r=gps · b8176d94
      Ted Mielczarek authored
      Several source files use DLL_PREFIX/DLL_SUFFIX defines, and they all
      set them in moz.build using `DEFINES`. This is problematic for the WSL build
      because the quoting gets lost somewhere between bash and cl.exe. This patch
      makes them set globally in moz.configure with `set_define`. There was an
      existing global `MOZ_DLL_SUFFIX` define that was only used in one place, so
      that has been removed in favor of simply `DLL_SUFFIX`.
      
      MozReview-Commit-ID: 4ZQiqMK8Dgu
      
      --HG--
      extra : rebase_source : f85cbb4b9e6dc69881f312182cd4e37985baf22e
      b8176d94
  12. Sep 12, 2017
  13. Sep 13, 2017
  14. Sep 12, 2017
  15. Sep 11, 2017
  16. Sep 14, 2017
    • J.C. Jones's avatar
      Bug 1399959 - Prefer hardware instead of software U2F tokens r=keeler · a986ec20
      J.C. Jones authored
      Bug 1388851 adds hardware U2F support to Gecko; the instructions to test
      involve flipping two prefs, but the common case will be using harwdare tokens,
      so this patch makes users only haave to flip the "security.webauth.u2f" or
      "security.webauth.webauthn" prefs as they choose.
      
      MozReview-Commit-ID: 346120ZI8p4
      
      --HG--
      extra : rebase_source : fa491214d3b5532ea7e4843a9e52a19ab432a925
      a986ec20
  17. Sep 10, 2017
  18. Sep 09, 2017
  19. Sep 05, 2017
    • J.C. Jones's avatar
      Bug 1245527 - Remove NSS U2F SoftToken. r=ttaubert, r=jed · 9ade50e6
      J.C. Jones authored
      The nsIU2FToken and its implementors are no longer needed; the soft token was
      re-implemented into dom/webauthn/U2FSoftTokenManager.cpp during the WebAuthn
      implementation. When the dom/u2f/ code changed to the implementation from
      WebAuthn, the old synchronous version became dead code.
      
      This patch removes the dead code.
      
      MozReview-Commit-ID: 2yDD0tccgZr
      
      --HG--
      extra : transplant_source : %B3%96Te%E7%02%08%98%1A%B2%FA%1C%40%C4J%BC%B2%85j%81
      9ade50e6
    • J.C. Jones's avatar
      Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler, r=ttaubert · 50501cbe
      J.C. Jones authored
      - This patch reworks the U2F module to asynchronously call U2FManager,
        which in turn handles constructing and managing the U2FTokenManager
        via IPC.
      - Add U2FTransaction{Parent,Child} implementations to mirror similar ones for
        WebAuthn
      - Rewrite all tests to compensate for U2F executing asynchronously now.
        - Used async tasks, used the manifest parameters for prefs and scheme,
          and generally made these cleaner.
      
      NOTE TO REVIEWERS:
       Since this is huge, I recommend the following:
      
       keeler - please review U2F.cpp/h, the tests, and the security-prefs.js. Most
                of the U2F logic is still in U2F.cpp like before, but there's been
                some reworking of how it is called.
      
       ttaubert - please review U2FManager, the Transaction classes, build changes,
                  and the changes to nsGlobalWindow. All of these should be very
                  similar to the WebAuthn code it's patterned off.
      
      
      MozReview-Commit-ID: C1ZN2ch66Rm
      
      --HG--
      extra : transplant_source : %EA%98%D2%87C%FD%CC%A5%3D%B5%9B%1C%DA%A5J%CD%05%94%13%0D
      50501cbe
  20. Sep 18, 2017
    • David Keeler's avatar
      bug 1400913 - back out the functionality changes from bug 1364159 (but keep the test) r=jcj · bae8112f
      David Keeler authored
      Bug 1364159 introduced an optimization that attempted to avoid reading from the
      user's cached certificate database as much as possible when building a verified
      certificate chain. Unfortunately this had the side-effect of not preferring root
      certificates in path building, which can result in unnecessarily long chains
      (which rather defeats the purpose, since it means more signature verifications).
      This patch reverts the functionality changes from that bug but keeps the test
      that was added (the test didn't directly test the functionality changes - it's
      more of a check that path building will query the cached certificate db when
      necessary).
      
      MozReview-Commit-ID: I56THTLUytH
      
      --HG--
      extra : rebase_source : 7db9597e25b98942450840519d707046cc660781
      bae8112f
  21. Sep 12, 2017
  22. Sep 01, 2017
  23. Sep 08, 2017
Loading