Skip to content
Snippets Groups Projects
  1. Sep 15, 2017
  2. Sep 18, 2017
    • Nicholas Nethercote's avatar
      Bug 1400624 - Fix a panic in Stylo memory reporting. r=heycam. · 887dab3c
      Nicholas Nethercote authored
      `MallocSizeOfOps::enclosing_size_of_op` is an `Option<>` type, and the panic in
      question is caused by not providing a value in a case where it's needed for
      measuring a HashSet.
      
      HashMaps and HashSets are common enough that it makes sense to make
      `enclosing_size_of_op` non-optional, which this patch does.
      
      MozReview-Commit-ID: IB2aRuXHj8E
      
      --HG--
      extra : rebase_source : a6f593b718ca9e92a7a36ca7e2063a01e11c7e04
      887dab3c
    • Nicholas Nethercote's avatar
      servo: Merge #18549 - Fix a panic in Stylo memory reporting (from... · 880f0bb7
      Nicholas Nethercote authored
      servo: Merge #18549 - Fix a panic in Stylo memory reporting (from nnethercote:fix-enclosing-crash); r=heycam
      
      `MallocSizeOfOps::enclosing_size_of_op` is an `Option<>` type, and the panic in
      question is caused by not providing a value in a case where it's needed for
      measuring a HashSet.
      
      HashMaps and HashSets are common enough that it makes sense to make
      `enclosing_size_of_op` non-optional, which this patch does.
      
      <!-- Please describe your changes on the following line: -->
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [ ] These changes fix #__ (github issue number if applicable).
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [X] These changes do not require tests because tests are on the Gecko side.
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: bb998dbdf31920d5ddc2a91d6bdfe8a880e11604
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 18ff3083b36733a2a212f094f249b46872b4ec61
      880f0bb7
  3. Sep 17, 2017
  4. Sep 16, 2017
  5. Sep 18, 2017
  6. Sep 16, 2017
  7. Sep 11, 2017
    • John Lin's avatar
      Bug 1394239 - don't return video frames that MDSM won't show. r=jya · ac062e70
      John Lin authored
      In some Android ROMs, MediaCodec doesn't allocate additional buffers to reduce
      consumer starvation and will not work when MDSM grips most recently returned
      frame before rearching seek target. Implement SetSeekThreshold() to get actual
      seek target to check if video buffers can be released back to remote decoder
      immediately.
      
      MozReview-Commit-ID: 7IetuVxCXc0
      
      --HG--
      extra : rebase_source : 8e8643dbde757d41a26de45663a8232b4c66c386
      ac062e70
  8. Sep 14, 2017
  9. Sep 15, 2017
    • Nicholas Nethercote's avatar
      Bug 1400100 - Shrink css::ImageValue. r=njn. · 0e7649f6
      Nicholas Nethercote authored
      This reduces sizeof(ImageValue) from 104 to 96. When heap-allocated, this moves
      it from the 112 byte bin to the 96 byte bin. Loading gmail with Stylo, there
      are about 11,500 ImageValues on the heap, so this saves about 184,000 bytes.
      
      MozReview-Commit-ID: JLe2cJ54IlL
      
      --HG--
      extra : rebase_source : 6c74d1d606db0cb1d09392f5585cc1cbadc92ebd
      0e7649f6
  10. Sep 17, 2017
  11. Sep 16, 2017
  12. Sep 17, 2017
  13. Sep 15, 2017
    • Daniel Holbert's avatar
      Bug 1400421 part 2: Delete unused nsLeafFrame::Reflow override (and its DoReflow helper). r=mats · b3a1c3da
      Daniel Holbert authored
      nsLeafFrame only exists as an abstract superclass, and every subclass actually
      brings along its own Reflow impl, so nsLeafFrame's own impl is just dead code.
      
      This patch makes sure it's really dead code by leaving in the Reflow() decl
      with " = 0;" so the compiler will enforce that all concrete subclasses *do*
      have a more specific override (and that they don't just inherit the stub
      nsFrame impl from further up the ancestor chain, for example).
      
      MozReview-Commit-ID: Co36IpuaeOc
      
      --HG--
      extra : rebase_source : 036caa3abaed0a1cf75e8674af4ae2e8b55b3b8c
      b3a1c3da
    • Daniel Holbert's avatar
      Bug 1400421 part 1: Annotate class 'nsPageBreakFrame' as final, to reflect reality. r=mats · 5190426f
      Daniel Holbert authored
      (This was the only concrete nsLeafBoxFrame subclass that was missing this
      annotation.  So, after this patch, all concrete nsLeafBoxFrame subclasses will
      have this annotation. Nice!)
      
      MozReview-Commit-ID: Iu1LaLTTqzu
      
      --HG--
      extra : rebase_source : d11f0391c9fed77c805b7bfb71cc39ed729a3f8f
      5190426f
  14. Sep 17, 2017
    • Emilio Cobos Álvarez's avatar
      servo: Merge #18537 - style: Spring cleanup (from emilio:spring-cleanup); r=nox · 5958fdc2
      Emilio Cobos Álvarez authored
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 14529da2a3c9a84cdec5735fca09d0bcb5995348
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 08675ea399bb6360cd2bd5ac84c2aff08f5facfc
      5958fdc2
    • Chris Peterson's avatar
      Bug 1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag... · 793bc692
      Chris Peterson authored
      Bug 1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings). r=lsalzman
      
      * The -Wno-unused-but-set-variable flag is supported by gcc but not clang, so move it to a gcc-only CFLAGS.
      
      * The -Wno-error=uninitialized flag is supported by both gcc and clang, so move it to CFLAGS shared by gcc and clang.
      
      * Also suppress -Wunreachable-code and -Wshift-negative-value clang warnings. gcc supports -Wshift-negative-value, but only starting in gcc 6.1 and we are still using gcc 4.9 in automation.
      
      warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]
      gfx/cairo/cairo/src/cairo-quartz-surface.c:1908:6: warning: code will never be executed [-Wunreachable-code]
      gfx/cairo/libpixman/src/pixman-bits-image.c:268:32: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
      
      MozReview-Commit-ID: AnQAsfDaZbk
      
      --HG--
      extra : rebase_source : 6dd94a39479e05f67f93d4e4be2bd10ece4df7be
      extra : source : 34ddaea5129be2ae1e9faa0a1d905b8690909611
      793bc692
    • Gijs Kruitbosch's avatar
      Bug 1400681 - remove footer inline start padding explicitly instead of not... · d9c533ac
      Gijs Kruitbosch authored
      Bug 1400681 - remove footer inline start padding explicitly instead of not setting non-icon inline start padding, r=johannh
      
      Using ':not' would unduly increase the specificity of the '.subviewbutton > .toolbarbutton-text' rule,
      so I went with overriding it instead.
      
      MozReview-Commit-ID: 85o0IcjCgbQ
      
      --HG--
      extra : rebase_source : 385bcd09c2cea5c24a99bb23c60da63b5a46749d
      d9c533ac
  15. Sep 16, 2017
  16. Sep 17, 2017
Loading