Skip to content
Snippets Groups Projects
  1. Aug 25, 2017
  2. Aug 23, 2017
  3. Aug 09, 2017
  4. Aug 21, 2017
  5. Aug 23, 2017
  6. Aug 24, 2017
  7. Aug 23, 2017
    • Jan Henning's avatar
      Bug 1390140 - Account for bookmark ID being <null> when populating... · 19fcb48e
      Jan Henning authored
      Bug 1390140 - Account for bookmark ID being <null> when populating BrowserSearch's HomeContextMenuInfo. r=Grisha
      
      The combined history view returns a bookmark ID of <null> for items that aren't a bookmark. Calling cursor.getInt() silently turns this into an ID of 0, which doesn't play well with the rest of our code that assumes that the bookmark ID for items that aren't in fact bookmarks is -1.
      
      When pressing "Remove" on a search history result, this means that we then end up trying to remove bookmark 0, i.e. the root "bookmark". Luckily this attempt doesn't succeed, but unfortunately still manages to crash the browser along the way.
      
      MozReview-Commit-ID: FZk4cI2EDAE
      
      --HG--
      extra : rebase_source : c35a8c3eabeb8607392e073df0d697585e78c64c
      19fcb48e
  8. Aug 24, 2017
  9. Aug 14, 2017
  10. Aug 24, 2017
  11. Aug 25, 2017
  12. Aug 24, 2017
Loading