Skip to content
Snippets Groups Projects
  1. Sep 18, 2017
  2. Sep 15, 2017
  3. Sep 18, 2017
    • Nicholas Nethercote's avatar
      Bug 1400624 - Fix a panic in Stylo memory reporting. r=heycam. · 887dab3c
      Nicholas Nethercote authored
      `MallocSizeOfOps::enclosing_size_of_op` is an `Option<>` type, and the panic in
      question is caused by not providing a value in a case where it's needed for
      measuring a HashSet.
      
      HashMaps and HashSets are common enough that it makes sense to make
      `enclosing_size_of_op` non-optional, which this patch does.
      
      MozReview-Commit-ID: IB2aRuXHj8E
      
      --HG--
      extra : rebase_source : a6f593b718ca9e92a7a36ca7e2063a01e11c7e04
      887dab3c
    • Nicholas Nethercote's avatar
      servo: Merge #18549 - Fix a panic in Stylo memory reporting (from... · 880f0bb7
      Nicholas Nethercote authored
      servo: Merge #18549 - Fix a panic in Stylo memory reporting (from nnethercote:fix-enclosing-crash); r=heycam
      
      `MallocSizeOfOps::enclosing_size_of_op` is an `Option<>` type, and the panic in
      question is caused by not providing a value in a case where it's needed for
      measuring a HashSet.
      
      HashMaps and HashSets are common enough that it makes sense to make
      `enclosing_size_of_op` non-optional, which this patch does.
      
      <!-- Please describe your changes on the following line: -->
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [ ] These changes fix #__ (github issue number if applicable).
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [X] These changes do not require tests because tests are on the Gecko side.
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: bb998dbdf31920d5ddc2a91d6bdfe8a880e11604
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 18ff3083b36733a2a212f094f249b46872b4ec61
      880f0bb7
  4. Sep 17, 2017
  5. Sep 16, 2017
  6. Sep 18, 2017
  7. Sep 16, 2017
  8. Sep 15, 2017
  9. Sep 18, 2017
  10. Sep 15, 2017
  11. Sep 17, 2017
  12. Sep 16, 2017
  13. Sep 17, 2017
  14. Sep 16, 2017
  15. Sep 15, 2017
    • Johann Hofmann's avatar
      Bug 1399930 - Add drag space padding to the tabs toolbar on OSX. r=Gijs · 3b3f324e
      Johann Hofmann authored
      The previous drag space was only set as min-height on the titlebar,
      which led tabsintitlebar.js to not account that extra space for moving
      the titlebar to the bottom (because it calculates that height from
      tab strip height). So while it looked fine visually, the titlebar did
      not stretch all the way to the bottom, so that e.g. double-clicks aren't
      registered correctly.
      
      MozReview-Commit-ID: 1mHFDBUe3sC
      
      --HG--
      extra : rebase_source : 667b131485658927fc2f3d484b2ab15cce782d95
      3b3f324e
    • Eden Chuang's avatar
      Bug 1398991 - Mochitest for spec change on PaymentRequest.shippingOption. r=baku · 62b089b5
      Eden Chuang authored
      This patch changes the test_construction.html with following modification.
      1. Modify the test testWithDuplicateShippingOptionsParameters to expect a
         TypeError when constructing wiht duplicate shippingOption ids.
      2. Add test testShippingOtpionAttribute for shippingOption setting checking
         with following conditions
         1. No selected shippingOption and PaymentOptions.requestShipping is false
         2. One selected shippingOption and PaymentOptions.requestShipping is false
         3. One selected shippingOption and PaymentOptions.requestShipping is true
         4. Multiple selected shippingOptions and PaymentOptions.requestShipping is
            true.
      62b089b5
    • Eden Chuang's avatar
      Bug 1398991 - Set PaymentRequest.ShippingOption only if options.requestShipping is true. r=baku · a15d19dc
      Eden Chuang authored
      This patch implements the following changes according to the spec change.
      See https://w3c.github.io/payment-request/#constructor step 8 for more
      details.
      
      1. Return TypeError during PaymentRequest construction with duplicate
         shippingOption id.
      2. Set PaymentRequest.shippingOption with the selected shippingOption only
         if options.requestShipping is true.
      a15d19dc
  16. Sep 17, 2017
Loading