Skip to content
Snippets Groups Projects
  1. Jan 20, 2020
    • Emilio Cobos Álvarez's avatar
      Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj · 256c124f
      Emilio Cobos Álvarez authored
      This was done by:
      
      This was done by applying:
      
      ```
      diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      index 789affde7bbf..fe33c4c7d4d1 100644
      --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
               from subprocess import Popen, PIPE, check_output, CalledProcessError
      
               diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
      -        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
      +        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
      
               if not output_file:
                   args.append("-i")
      ```
      
      Then running `./mach clang-format -c <commit-hash>`
      
      Then undoing that patch.
      
      Then running check_spidermonkey_style.py --fixup
      
      Then running `./mach clang-format`
      
      I had to fix four things:
      
       * I needed to move <utility> back down in GuardObjects.h because I was hitting
         obscure problems with our system include wrappers like this:
      
      0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
      0:03.94 extern void *realloc (void *__ptr, size_t __size)
      0:03.94              ^
      0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
      0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
      0:03.94 ^
      0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
      0:03.94     MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
      0:03.94                                ^
      0:03.94 <scratch space>:178:1: note: expanded from here
      0:03.94 realloc_impl
      0:03.94 ^
      0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
      0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)
      
         Which I really didn't feel like digging into.
      
       * I had to restore the order of TrustOverrideUtils.h and related files in nss
         because the .inc files depend on TrustOverrideUtils.h being included earlier.
      
       * I had to add a missing include to RollingNumber.h
      
       * Also had to partially restore include order in JsepSessionImpl.cpp to avoid
         some -WError issues due to some static inline functions being defined in a
         header but not used in the rest of the compilation unit.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60327
      
      --HG--
      extra : moz-landing-system : lando
      256c124f
    • Emilio Cobos Álvarez's avatar
      Bug 1609996 - Remove mozilla/Move.h. r=froydnj · aa3a6957
      Emilio Cobos Álvarez authored
      rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'
      
      Further manual fixups and cleanups to the include order incoming.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60323
      
      --HG--
      extra : moz-landing-system : lando
      aa3a6957
  2. Apr 05, 2019
  3. Apr 04, 2019
  4. Nov 30, 2018
  5. Oct 12, 2018
  6. Jun 01, 2018
  7. Sep 11, 2017
  8. Mar 23, 2017
  9. Jan 14, 2017
  10. Oct 11, 2016
    • Chris Pearce's avatar
      Bug 1308076 - Ensure Primetime PSSH boxes pass the PSSH validator. r=jwwang · c0fc92ff
      Chris Pearce authored
      Primetime PSSH boxes don't use the common encryption system ID.
      So to ensure we don't break any existing Primetime players, we
      must allow PSSH boxes with the Primetime system ID to pass the
      PSSH validator.
      
      MozReview-Commit-ID: 3q58FKLQXgV
      
      --HG--
      extra : rebase_source : a7a0ca3d38fb027ad6de23d8260043b3193536f4
      extra : source : b94fe60732fb7d3a6630c976284eaabd28b271f3
      c0fc92ff
  11. Oct 07, 2016
  12. Oct 06, 2016
    • Chris Pearce's avatar
      Bug 1308076 - Rename CLEARKEY_KEY_LEN to CENC_KEY_LEN. r=jwwang · 3bb7ad59
      Chris Pearce authored
      This better reflects that it's used for all CENC keys, not just ClearKey keys.
      
      MozReview-Commit-ID: 9uCzDKVDLjc
      
      --HG--
      extra : source : 3307b3e0d411ceb9888f10afdbebc07ab9efce61
      3bb7ad59
    • Chris Pearce's avatar
      Bug 1308076 - Use PsshParser to validate CENC init data. r=jwwang · ef74aeb8
      Chris Pearce authored
      Now that we can link gmp-clearkey's PSSH parser into Gecko, we can
      simply use that inside MediaKeySession to validate that the CENC
      init data matches the spec.
      
      This change enforces that CENC init data uses the common system Id.
      As far as I can tell, Widevine only uses that now.
      
      MozReview-Commit-ID: HrlKQHcv5DI
      
      --HG--
      extra : source : f61138f1030e87026eb432e83d36e46c81e55b33
      ef74aeb8
    • Chris Pearce's avatar
      Bug 1308076 - Move ClearKeyCencParser to PsshParser library. r=glandium · 35e13f72
      Chris Pearce authored
      To validate the PSSH init data passed to EME, I'd like to reuse the same
      PSSH parser that the ClearKey CDM shared library uses. So move the code
      out of gmp-clearkey and into its own library, so we can link it statically
      into code that needs to use it.
      
      
      
      MozReview-Commit-ID: 7xSUSmCueJz
      
      --HG--
      rename : media/gmp-clearkey/0.1/ClearKeyCencParser.cpp => media/psshparser/PsshParser.cpp
      rename : media/gmp-clearkey/0.1/ClearKeyCencParser.h => media/psshparser/PsshParser.h
      extra : source : 78dcbc5d3c26547c63269eb14034a67863cf28de
      35e13f72
  13. Oct 11, 2016
  14. Oct 07, 2016
  15. Oct 06, 2016
    • Chris Pearce's avatar
      Bug 1308076 - Rename CLEARKEY_KEY_LEN to CENC_KEY_LEN. r=jwwang · a0900b69
      Chris Pearce authored
      This better reflects that it's used for all CENC keys, not just ClearKey keys.
      
      MozReview-Commit-ID: 9uCzDKVDLjc
      
      --HG--
      extra : rebase_source : dfd7fe864be6825a86dfed4f60b448a5edac286f
      a0900b69
    • Chris Pearce's avatar
      Bug 1308076 - Use PsshParser to validate CENC init data. r=jwwang · d4606df7
      Chris Pearce authored
      Now that we can link gmp-clearkey's PSSH parser into Gecko, we can
      simply use that inside MediaKeySession to validate that the CENC
      init data matches the spec.
      
      This change enforces that CENC init data uses the common system Id.
      As far as I can tell, Widevine only uses that now.
      
      MozReview-Commit-ID: HrlKQHcv5DI
      
      --HG--
      extra : rebase_source : ccf8e217d87dfa85478578f52469dc7383fd6c9b
      d4606df7
    • Chris Pearce's avatar
      Bug 1308076 - Move ClearKeyCencParser to PsshParser library. r=glandium · 10c6ab25
      Chris Pearce authored
      To validate the PSSH init data passed to EME, I'd like to reuse the same
      PSSH parser that the ClearKey CDM shared library uses. So move the code
      out of gmp-clearkey and into its own library, so we can link it statically
      into code that needs to use it.
      
      
      
      MozReview-Commit-ID: 7xSUSmCueJz
      
      --HG--
      rename : media/gmp-clearkey/0.1/ClearKeyCencParser.cpp => media/psshparser/PsshParser.cpp
      rename : media/gmp-clearkey/0.1/ClearKeyCencParser.h => media/psshparser/PsshParser.h
      extra : rebase_source : 3f621aa1d99c6a73f6b5f3ca9d1f84022266a833
      10c6ab25
Loading