- Jan 20, 2020
-
-
Emilio Cobos Álvarez authored
This was done by: This was done by applying: ``` diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py index 789affde7bbf..fe33c4c7d4d1 100644 --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase): from subprocess import Popen, PIPE, check_output, CalledProcessError diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE) - args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format] + args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes'] if not output_file: args.append("-i") ``` Then running `./mach clang-format -c <commit-hash>` Then undoing that patch. Then running check_spidermonkey_style.py --fixup Then running `./mach clang-format` I had to fix four things: * I needed to move <utility> back down in GuardObjects.h because I was hitting obscure problems with our system include wrappers like this: 0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration 0:03.94 extern void *realloc (void *__ptr, size_t __size) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here 0:03.94 MALLOC_DECL(realloc, void*, void*, size_t) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL' 0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__); 0:03.94 ^ 0:03.94 <scratch space>:178:1: note: expanded from here 0:03.94 realloc_impl 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl' 0:03.94 #define realloc_impl mozmem_malloc_impl(realloc) Which I really didn't feel like digging into. * I had to restore the order of TrustOverrideUtils.h and related files in nss because the .inc files depend on TrustOverrideUtils.h being included earlier. * I had to add a missing include to RollingNumber.h * Also had to partially restore include order in JsepSessionImpl.cpp to avoid some -WError issues due to some static inline functions being defined in a header but not used in the rest of the compilation unit. Differential Revision: https://phabricator.services.mozilla.com/D60327 --HG-- extra : moz-landing-system : lando
-
Emilio Cobos Álvarez authored
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g' Further manual fixups and cleanups to the include order incoming. Differential Revision: https://phabricator.services.mozilla.com/D60323 --HG-- extra : moz-landing-system : lando
-
- Apr 05, 2019
-
-
Sylvestre Ledru authored
# ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D26280 --HG-- extra : moz-landing-system : lando
-
Csoregi Natalia authored
Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE
-
- Apr 04, 2019
-
-
Sylvestre Ledru authored
clang-format-8 upstream had some improvements wrt macros See: https://reviews.llvm.org/D33440 This is why the diff is bigger than usual # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D26098 --HG-- extra : moz-landing-system : lando
-
Narcis Beleuzu authored
-
Sylvestre Ledru authored
clang-format-8 upstream had some improvements wrt macros See: https://reviews.llvm.org/D33440 This is why the diff is bigger than usual # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D26098 --HG-- extra : moz-landing-system : lando
-
- Nov 30, 2018
-
-
Sylvestre Ledru authored
# ignore-this-changeset --HG-- extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
-
- Oct 12, 2018
-
-
Sylvestre Ledru authored
Too hard/impossible for the tool to format correctly these structs Differential Revision: https://phabricator.services.mozilla.com/D8569 --HG-- extra : moz-landing-system : lando
-
- Jun 01, 2018
-
-
Emilio Cobos Álvarez authored
This was done automatically replacing: s/mozilla::Move/std::move/ s/ Move(/ std::move(/ s/(Move(/(std::move(/ Removing the 'using mozilla::Move;' lines. And then with a few manual fixups, see the bug for the split series.. MozReview-Commit-ID: Jxze3adipUh
-
- Sep 11, 2017
-
-
Chris Manchester authored
Bug 1386876 - Replace all uses of DISABLE_STL_WRAPPING with a template, remove DISABLE_STL_WRAPPING. r=glandium MozReview-Commit-ID: FMEtb5PY7iP --HG-- extra : rebase_source : 3cdee7528846462c758e623d6bcd2e6e17dbabff
-
- Mar 23, 2017
-
-
Wes Kocher authored
MozReview-Commit-ID: 3ItJdCtiOul --HG-- extra : rebase_source : 2db0d75589a0bd8f28bdd35f015949a1194bc47d
-
- Jan 14, 2017
-
-
Chris Pearce authored
MozReview-Commit-ID: JzhhMFpzyjg --HG-- extra : rebase_source : 59f7aa955d3bc3849e980797d5eaa84293a5f1bf
-
- Oct 11, 2016
-
-
Chris Pearce authored
Primetime PSSH boxes don't use the common encryption system ID. So to ensure we don't break any existing Primetime players, we must allow PSSH boxes with the Primetime system ID to pass the PSSH validator. MozReview-Commit-ID: 3q58FKLQXgV --HG-- extra : rebase_source : a7a0ca3d38fb027ad6de23d8260043b3193536f4 extra : source : b94fe60732fb7d3a6630c976284eaabd28b271f3
-
- Oct 07, 2016
-
-
Chris Pearce authored
MozReview-Commit-ID: G760z2sIQpO --HG-- rename : media/gmp-clearkey/0.1/gtest/TestClearKeyUtils.cpp => media/psshparser/gtest/TestPsshParser.cpp rename : media/gmp-clearkey/0.1/gtest/moz.build => media/psshparser/gtest/moz.build extra : source : a409d51e3efa0099344ff4b8ebc414ddb50ce829
-
Chris Pearce authored
We're now obliged to be stricter, taking from the example of the Web Platform Tests. MozReview-Commit-ID: AJNDoRZ9BF8 --HG-- extra : source : 5180fdf042b03362b882ceb3a8ac0e664049bd64
-
- Oct 06, 2016
-
-
Chris Pearce authored
This better reflects that it's used for all CENC keys, not just ClearKey keys. MozReview-Commit-ID: 9uCzDKVDLjc --HG-- extra : source : 3307b3e0d411ceb9888f10afdbebc07ab9efce61
-
Chris Pearce authored
Now that we can link gmp-clearkey's PSSH parser into Gecko, we can simply use that inside MediaKeySession to validate that the CENC init data matches the spec. This change enforces that CENC init data uses the common system Id. As far as I can tell, Widevine only uses that now. MozReview-Commit-ID: HrlKQHcv5DI --HG-- extra : source : f61138f1030e87026eb432e83d36e46c81e55b33
-
Chris Pearce authored
To validate the PSSH init data passed to EME, I'd like to reuse the same PSSH parser that the ClearKey CDM shared library uses. So move the code out of gmp-clearkey and into its own library, so we can link it statically into code that needs to use it. MozReview-Commit-ID: 7xSUSmCueJz --HG-- rename : media/gmp-clearkey/0.1/ClearKeyCencParser.cpp => media/psshparser/PsshParser.cpp rename : media/gmp-clearkey/0.1/ClearKeyCencParser.h => media/psshparser/PsshParser.h extra : source : 78dcbc5d3c26547c63269eb14034a67863cf28de
-
- Oct 11, 2016
-
-
Sebastian Hengst authored
--HG-- rename : media/psshparser/PsshParser.cpp => media/gmp-clearkey/0.1/ClearKeyCencParser.cpp rename : media/psshparser/PsshParser.h => media/gmp-clearkey/0.1/ClearKeyCencParser.h
-
Sebastian Hengst authored
-
Sebastian Hengst authored
-
Sebastian Hengst authored
-
Sebastian Hengst authored
-
Sebastian Hengst authored
-
Chris Pearce authored
Primetime PSSH boxes don't use the common encryption system ID. So to ensure we don't break any existing Primetime players, we must allow PSSH boxes with the Primetime system ID to pass the PSSH validator. MozReview-Commit-ID: 3q58FKLQXgV --HG-- extra : rebase_source : aac2a8349d8e9dfccae3c37a47549245fb1fc0e3
-
- Oct 07, 2016
-
-
Chris Pearce authored
MozReview-Commit-ID: G760z2sIQpO --HG-- rename : media/gmp-clearkey/0.1/gtest/TestClearKeyUtils.cpp => media/psshparser/gtest/TestPsshParser.cpp rename : media/gmp-clearkey/0.1/gtest/moz.build => media/psshparser/gtest/moz.build extra : rebase_source : 80fc084137ca84f9263cb056c27f296b8f05111c
-
Chris Pearce authored
We're now obliged to be stricter, taking from the example of the Web Platform Tests. MozReview-Commit-ID: AJNDoRZ9BF8 --HG-- extra : rebase_source : 79b13d1d7d1b6b6b4a382b6a17af81606af608fa
-
- Oct 06, 2016
-
-
Chris Pearce authored
This better reflects that it's used for all CENC keys, not just ClearKey keys. MozReview-Commit-ID: 9uCzDKVDLjc --HG-- extra : rebase_source : dfd7fe864be6825a86dfed4f60b448a5edac286f
-
Chris Pearce authored
Now that we can link gmp-clearkey's PSSH parser into Gecko, we can simply use that inside MediaKeySession to validate that the CENC init data matches the spec. This change enforces that CENC init data uses the common system Id. As far as I can tell, Widevine only uses that now. MozReview-Commit-ID: HrlKQHcv5DI --HG-- extra : rebase_source : ccf8e217d87dfa85478578f52469dc7383fd6c9b
-
Chris Pearce authored
To validate the PSSH init data passed to EME, I'd like to reuse the same PSSH parser that the ClearKey CDM shared library uses. So move the code out of gmp-clearkey and into its own library, so we can link it statically into code that needs to use it. MozReview-Commit-ID: 7xSUSmCueJz --HG-- rename : media/gmp-clearkey/0.1/ClearKeyCencParser.cpp => media/psshparser/PsshParser.cpp rename : media/gmp-clearkey/0.1/ClearKeyCencParser.h => media/psshparser/PsshParser.h extra : rebase_source : 3f621aa1d99c6a73f6b5f3ca9d1f84022266a833
-