Skip to content
Snippets Groups Projects
Forked from The Tor Project / Core / Tor
Source project has a limited visibility.
  • teor's avatar
    8a0ea3ee
    Use a temporary service list when validating and adding hidden services · 8a0ea3ee
    teor authored
    This resolves two issues:
    * the checks in rend_add_services were only being performed when adding
      the service, and not when the service was validated,
      (this meant that duplicate checks were not being performed, and some SETCONF
      commands appeared to succeed when they actually failed), and
    * if one service failed while services were being added, then the service
      list would be left in an inconsistent state (tor dies when this happens,
      but the code is cleaner now).
    
    Fixes #20860.
    Use a temporary service list when validating and adding hidden services
    teor authored
    This resolves two issues:
    * the checks in rend_add_services were only being performed when adding
      the service, and not when the service was validated,
      (this meant that duplicate checks were not being performed, and some SETCONF
      commands appeared to succeed when they actually failed), and
    * if one service failed while services were being added, then the service
      list would be left in an inconsistent state (tor dies when this happens,
      but the code is cleaner now).
    
    Fixes #20860.