Skip to content
Snippets Groups Projects
Forked from The Tor Project / Core / Tor
15326 commits behind the upstream repository.
  • Mike Perry's avatar
    e8d84b18
    Bug 25733: Avoid assert failure if all circuits time out. · e8d84b18
    Mike Perry authored and teor's avatar teor committed
    Prior to #23100, we were not counting HS circuit build times in our
    calculation of the timeout. This could lead to a condition where our timeout
    was set too low, based on non HS circuit build times, and then we would
    abandon all HS circuits, storing no valid timeouts in the histogram.
    
    This commit avoids the assert.
    Bug 25733: Avoid assert failure if all circuits time out.
    Mike Perry authored and teor's avatar teor committed
    Prior to #23100, we were not counting HS circuit build times in our
    calculation of the timeout. This could lead to a condition where our timeout
    was set too low, based on non HS circuit build times, and then we would
    abandon all HS circuits, storing no valid timeouts in the histogram.
    
    This commit avoids the assert.
bug25733 200 B
  o Minor bugfixes (Assert crash):
    - Avoid an assert in the circuit build timeout code if we fail to
      allow any circuits to actually complete. Fixes bug 25733;
      bugfix on 0.2.2.2-alpha.