-
- Downloads
Fix names of functions that convert strings to addrs
Now let's have "lookup" indicate that there can be a hostname resolution, and "parse" indicate that there wasn't. Previously, we had one "lookup" function that did resolution; four "parse" functions, half of which did resolution; and a "from_str()" function that didn't do resolution. That's confusing and error-prone! The code changes in this commit are exactly the result of this perl script, run under "perl -p -i.bak" : s/tor_addr_port_parse/tor_addr_port_lookup/g; s/parse_addr_port(?=[^_])/addr_port_lookup/g; s/tor_addr_from_str/tor_addr_parse/g; This patch leaves aton and pton alone: their naming convention and behavior is is determined by the sockets API. More renaming may be needed.
Showing
- changes/bug3512 6 additions, 0 deletionschanges/bug3512
- src/common/address.c 4 additions, 4 deletionssrc/common/address.c
- src/common/address.h 3 additions, 3 deletionssrc/common/address.h
- src/or/circuituse.c 2 additions, 2 deletionssrc/or/circuituse.c
- src/or/config.c 16 additions, 16 deletionssrc/or/config.c
- src/or/connection.c 2 additions, 2 deletionssrc/or/connection.c
- src/or/connection_edge.c 3 additions, 3 deletionssrc/or/connection_edge.c
- src/or/dirserv.c 1 addition, 1 deletionsrc/or/dirserv.c
- src/or/dns.c 2 additions, 2 deletionssrc/or/dns.c
- src/or/rendservice.c 1 addition, 1 deletionsrc/or/rendservice.c
- src/or/routerparse.c 3 additions, 3 deletionssrc/or/routerparse.c
- src/or/transports.c 2 additions, 2 deletionssrc/or/transports.c
- src/test/test_addr.c 8 additions, 8 deletionssrc/test/test_addr.c
- src/tools/tor-gencert.c 1 addition, 1 deletionsrc/tools/tor-gencert.c
- src/tools/tor-resolve.c 1 addition, 1 deletionsrc/tools/tor-resolve.c
Loading
Please register or sign in to comment